Bug 68174 - [Chromium] Add movementX/Y members to WebInputEvent
Summary: [Chromium] Add movementX/Y members to WebInputEvent
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Vincent Scheib
Depends on:
Reported: 2011-09-15 11:23 PDT by Vincent Scheib
Modified: 2011-09-16 20:22 PDT (History)
3 users (show)

See Also:

Patch (1.37 KB, patch)
2011-09-15 11:32 PDT, Vincent Scheib
fishd: review+
fishd: commit-queue-
Details | Formatted Diff | Diff
Patch (1.41 KB, patch)
2011-09-16 07:44 PDT, Vincent Scheib
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Vincent Scheib 2011-09-15 11:23:17 PDT
[Chromium] Add movementX/Y members to WebInputEvent
Comment 1 Vincent Scheib 2011-09-15 11:32:44 PDT
Created attachment 107518 [details]
Comment 2 Darin Fisher (:fishd, Google) 2011-09-15 23:03:42 PDT
Comment on attachment 107518 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=107518&action=review

> Source/WebKit/chromium/ChangeLog:3
> +        [Chromium] Add movementX/Y members to WebInputEvent

nit: This should say WebMouseEvent instead of WebInputEvent
Comment 3 Vincent Scheib 2011-09-16 07:44:17 PDT
Created attachment 107649 [details]
Comment 4 WebKit Review Bot 2011-09-16 07:46:39 PDT
Comment on attachment 107649 [details]

Rejecting attachment 107649 [details] from commit-queue.

scheib@chromium.org does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.
Comment 5 WebKit Review Bot 2011-09-16 20:22:14 PDT
Comment on attachment 107649 [details]

Clearing flags on attachment: 107649

Committed r95359: <http://trac.webkit.org/changeset/95359>
Comment 6 WebKit Review Bot 2011-09-16 20:22:18 PDT
All reviewed patches have been landed.  Closing bug.