Bug 68158 - Don't bother calculating dirty rect for accelerated 2D canvases.
Summary: Don't bother calculating dirty rect for accelerated 2D canvases.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Canvas (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-15 07:06 PDT by Andreas Kling
Modified: 2011-09-15 09:09 PDT (History)
2 users (show)

See Also:

Attachments
Proposed patch (2.62 KB, patch)
2011-09-15 07:07 PDT, Andreas Kling 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2011-09-15 07:06:20 PDT 
CanvasRenderingContext2D::didDraw() currently calculates the dirty rect for invalidation, but if the canvas is accelerated and has an AC layer, we don't use the dirty rect, but simply call RenderLayer::contentChanged().
Comment 1 Andreas Kling 2011-09-15 07:07:05 PDT 
Created attachment 107490 [details]
Proposed patch
Comment 2 Kenneth Rohde Christiansen 2011-09-15 07:12:34 PDT 
Comment on attachment 107490 [details]
Proposed patch

Nice
Comment 3 WebKit Review Bot 2011-09-15 09:09:05 PDT 
Comment on attachment 107490 [details]
Proposed patch

Clearing flags on attachment: 107490

Committed r95193: <http://trac.webkit.org/changeset/95193>
Comment 4 WebKit Review Bot 2011-09-15 09:09:09 PDT 
All reviewed patches have been landed.  Closing bug.