RESOLVED FIXED68148
Implement an ErrorEvent constructor for JSC 
https://bugs.webkit.org/show_bug.cgi?id=68148
Summary Implement an ErrorEvent constructor for JSC
Kentaro Hara
Reported 2011-09-15 02:12:45 PDT
ErrorEvent should have a constructor (Spec: http://dev.w3.org/html5/workers/#errorevent). After this patch is landed, I will add the ErrorEvent constructor for V8 as a follow-up patch.
Attachments
Patch (24.17 KB, patch)
2011-09-15 04:11 PDT, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
Patch (21.92 KB, patch)
2011-09-15 11:23 PDT, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
rebased patch for commit (21.85 KB, patch)
2011-09-15 23:14 PDT, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Kentaro Hara
Comment 1 2011-09-15 04:11:08 PDT
Created attachment 107475 [details] Patch
Sam Weinig
Comment 2 2011-09-15 10:15:51 PDT
Comment on attachment 107475 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=107475&action=review > Source/WebCore/dom/ErrorEvent.h:78 > + unsigned long m_lineNumber; This should stay an unsigned int. unsigned long in WebIDL maps to unsigned int in C. Same with the the init.
Kentaro Hara
Comment 3 2011-09-15 11:23:16 PDT
Created attachment 107515 [details] Patch
Kentaro Hara
Comment 4 2011-09-15 23:14:40 PDT
Created attachment 107609 [details] rebased patch for commit
WebKit Review Bot
Comment 5 2011-09-16 19:00:35 PDT
Comment on attachment 107609 [details] rebased patch for commit Clearing flags on attachment: 107609 Committed r95352: <http://trac.webkit.org/changeset/95352>
WebKit Review Bot
Comment 6 2011-09-16 19:00:40 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.