Bug 68148 - Implement an ErrorEvent constructor for JSC
Summary: Implement an ErrorEvent constructor for JSC
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 67824
  Show dependency tree / graph
 
Reported: 2011-09-15 02:12 PDT by Kentaro Hara
Modified: 2011-09-16 19:00 PDT (History)
5 users (show)

See Also:

Attachments
Patch (24.17 KB, patch)
2011-09-15 04:11 PDT, Kentaro Hara 		no flags Details | Formatted Diff | Diff
Patch (21.92 KB, patch)
2011-09-15 11:23 PDT, Kentaro Hara 		no flags Details | Formatted Diff | Diff
rebased patch for commit (21.85 KB, patch)
2011-09-15 23:14 PDT, Kentaro Hara 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kentaro Hara 2011-09-15 02:12:45 PDT 
ErrorEvent should have a constructor (Spec: http://dev.w3.org/html5/workers/#errorevent). 

After this patch is landed, I will add the ErrorEvent constructor for V8 as a follow-up patch.
Comment 1 Kentaro Hara 2011-09-15 04:11:08 PDT 
Created attachment 107475 [details]
Patch
Comment 2 Sam Weinig 2011-09-15 10:15:51 PDT 
Comment on attachment 107475 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=107475&action=review

> Source/WebCore/dom/ErrorEvent.h:78
> +    unsigned long m_lineNumber;

This should stay an unsigned int.  unsigned long in WebIDL maps to unsigned int in C.  Same with the the init.
Comment 3 Kentaro Hara 2011-09-15 11:23:16 PDT 
Created attachment 107515 [details]
Patch
Comment 4 Kentaro Hara 2011-09-15 23:14:40 PDT 
Created attachment 107609 [details]
rebased patch for commit
Comment 5 WebKit Review Bot 2011-09-16 19:00:35 PDT 
Comment on attachment 107609 [details]
rebased patch for commit

Clearing flags on attachment: 107609

Committed r95352: <http://trac.webkit.org/changeset/95352>
Comment 6 WebKit Review Bot 2011-09-16 19:00:40 PDT 
All reviewed patches have been landed.  Closing bug.