Bug 68144 - Web Inspector: skip overlapping scripts when displaying concatenated content.
Summary: Web Inspector: skip overlapping scripts when displaying concatenated content.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Podivilov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-15 00:32 PDT by Pavel Podivilov
Modified: 2011-09-23 06:46 PDT (History)
10 users (show)

See Also:

Attachments
Patch (5.54 KB, patch)
2011-09-15 00:37 PDT, Pavel Podivilov 		pfeldman: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Podivilov 2011-09-15 00:32:41 PDT 
Web Inspector: skip overlapping scripts when displaying concatenated content.
Comment 1 Pavel Podivilov 2011-09-15 00:37:22 PDT 
Created attachment 107471 [details]
Patch
Comment 2 Pavel Feldman 2011-09-19 00:37:28 PDT 
Comment on attachment 107471 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=107471&action=review

> Source/WebCore/inspector/front-end/SourceFile.js:274
> +           if (lineNumber > scripts[i].lineOffset || (lineNumber === scripts[i].lineOffset && columnNumber > scripts[i].columnOffset - scriptOpenTag.length))

Could you also investigate when this happens? I.e. can we process scripts added via appendChild differently?
Comment 3 Pavel Podivilov 2011-09-23 06:46:31 PDT 
Committed r95797: <http://trac.webkit.org/changeset/95797>