Bug 68141 – [n]stricteq code is bogus in JSValue32_64 JIT

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Gavin Barraclough]

The code tries to check for both ints or cells, but this check also catches cases where values that are undefined, null, etc (probably was incorrectly assuming cell was the 2nd highest tag?).
Also, there is no need not to handle int on the fast path.
stricteq is just a case of comparing the payloads, if we:

* handle cases of differing tags on a slow path
* handle doubles a slow path
* handle both-are-string on a slow path

[Gavin Barraclough]

Created attachment 107453 [details]
The patch

[WebKit Review Bot]

Attachment 107453 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1

Source/JavaScriptCore/ChangeLog:14:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
Source/JavaScriptCore/ChangeLog:15:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
Source/JavaScriptCore/ChangeLog:16:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
Total errors found: 3 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Sam Weinig]

Comment on attachment 107453 [details]
The patch

View in context: https://bugs.webkit.org/attachment.cgi?id=107453&action=review

> Source/JavaScriptCore/jit/JITOpcodes32_64.cpp:1011
> +    // Simply compare the patyloads.

No patyloads here! Tyop!

[Gavin Barraclough]

Fixed in r95168