RESOLVED FIXED 68139
REGRESSION(r95145): The GTK+ build is working now, so revert this trial build fix. (Requested by mrobinson on #webkit). 
https://bugs.webkit.org/show_bug.cgi?id=68139
Summary REGRESSION(r95145): The GTK+ build is working now, so revert this trial build...
WebKit Review Bot
Reported 2011-09-14 21:16:45 PDT
http://trac.webkit.org/changeset/95145 broke the build: The GTK+ build is working now, so revert this trial build fix. (Requested by mrobinson on #webkit). This is an automatic bug report generated by the sheriff-bot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests case pain. "Only you can prevent forest fires." -- Smokey the Bear
Attachments
ROLLOUT of r95145 (1.51 KB, patch)
2011-09-14 21:17 PDT, WebKit Review Bot 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
WebKit Review Bot
Comment 1 2011-09-14 21:17:09 PDT
Created attachment 107449 [details] ROLLOUT of r95145 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID where ATTACHMENT_ID is the ID of this attachment.
WebKit Review Bot
Comment 2 2011-09-14 21:26:22 PDT
Comment on attachment 107449 [details] ROLLOUT of r95145 Clearing flags on attachment: 107449 Committed r95162: <http://trac.webkit.org/changeset/95162>
WebKit Review Bot
Comment 3 2011-09-14 21:26:26 PDT
All reviewed patches have been landed. Closing bug.
Tim Horton
Comment 4 2011-09-16 23:03:55 PDT
So, I'm still unable to build webkitgtk, and I just bisected the problem down to this commit. If I revert this change (effectively re-applying http://trac.webkit.org/changeset/95145), all is well. It looks like we're rolling over some sort of list-length limit or something!?! (i.e. I don't think it's related to the content of the files, just that we're making that list too long) I'm not really sure what's up, but I'm up for debugging at some point if anyone has any ideas... FWIW, I get a "GNUmakefile:66532: *** missing separator. Stop." When I look at that line, I see: maintainer-clean: maintainer-clean-am -rm -f $(am__CONFIG_DISTCLEAN_FILES) -rm -rf $(top_srcdir)/autom4te.cache urce/WebKit2/WebProcess/Downloads/soup/$(DEPDIR) Source/WebKit2/WebProcess/FullScre [CONTINUED for quite a while] -rm -f GNUmakefile Note that that line (66532) there a) is not indented and b) complete garbage, appearing to be truncated at the beginning.
Note You need to log in before you can comment on or make changes to this bug.