Bug 68138 - DFG does not speculate aggressively enough on comparisons
Summary: DFG does not speculate aggressively enough on comparisons
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-14 20:58 PDT by Filip Pizlo
Modified: 2011-09-15 09:13 PDT (History)
1 user (show)

See Also:


Attachments
the patch (13.26 KB, patch)
2011-09-14 21:35 PDT, Filip Pizlo
oliver: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2011-09-14 20:58:47 PDT
DFG will emit slow-path code for peephole comparisons even if we have a double prediction.  For non-peephole double comparisons, we always take a slow path.
Comment 1 Filip Pizlo 2011-09-14 21:35:32 PDT
Created attachment 107451 [details]
the patch

75% speed-up on Kraken/ai-astar.
Comment 2 Filip Pizlo 2011-09-15 00:28:03 PDT
Landed in r95172
Comment 3 Adam Roben (:aroben) 2011-09-15 09:13:33 PDT
Clang build fix in http://trac.webkit.org/changeset/95194