Bug 68137 - Use isAcceleratedContext() on the GraphicsContext instead of flags in ImageBuffer
Summary: Use isAcceleratedContext() on the GraphicsContext instead of flags in ImageBu...
Alias: None
Product: WebKit
Classification: Unclassified
Component: Canvas (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Matthew Delaney
Depends on: 68146
Blocks: 68041
  Show dependency treegraph
Reported: 2011-09-14 20:31 PDT by Matthew Delaney
Modified: 2011-09-15 00:52 PDT (History)
7 users (show)

See Also:

Patch (10.39 KB, patch)
2011-09-14 20:37 PDT, Matthew Delaney
simon.fraser: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Matthew Delaney 2011-09-14 20:31:16 PDT
The m_acceleratesRendering flag on ImageBuffer is no longer needed. Using the flag on the graphics context via isAcceleratedContext and setIsAcceleratedContext is sufficient and cleaner.
Comment 1 Matthew Delaney 2011-09-14 20:37:32 PDT
Created attachment 107447 [details]
Comment 2 Matthew Delaney 2011-09-14 23:54:48 PDT
Committed r95174: <http://trac.webkit.org/changeset/95174>
Comment 3 Andrey Kosyakov 2011-09-15 00:52:27 PDT
(In reply to comment #2)
> Committed r95174: <http://trac.webkit.org/changeset/95174>

This broke chromium build, e.g.:


>..\platform\graphics\skia\ImageBufferSkia.cpp(103) : error C2039: 'setIsAcceleratedContext' : is not a member of 'WebCore::GraphicsContext'
5>        e:\b\build\slave\Webkit_Win7\build\src\third_party\WebKit\Source\WebCore\platform\graphics\GraphicsContext.h(215) : see declaration of 'WebCore::GraphicsContext'