Bug 6813 - elementAtPoint needs to return input element when clicking on new text field
Summary: elementAtPoint needs to return input element when clicking on new text field
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 420+
Hardware: Macintosh OS X 10.4
: P2 Normal
Assignee: Adele Peterson
URL:
Keywords: InRadar
Depends on:
Blocks: 6986
  Show dependency treegraph
 
Reported: 2006-01-25 18:40 PST by Adele Peterson
Modified: 2006-03-21 17:06 PST (History)
0 users

See Also:


Attachments
patch (29.15 KB, patch)
2006-03-21 15:10 PST, Adele Peterson
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adele Peterson 2006-01-25 18:40:22 PST
Right now, elementAtPoint will return the inner div.  You can see this by trying to use the Web Inspector on the new text field.
Comment 1 Darin Adler 2006-01-28 17:12:38 PST
These bugs that block us switching to the new text field shoul not be marked P1.

Once we turn it on, these would be P1/major bugs, of course, but at the moment they are just part of the "switch to a new text field" task and should not be in the P1 list.
Comment 2 Adele Peterson 2006-03-01 16:59:16 PST
<rdar://problem/4463754> elementAtPoint needs to return input element when clicking on new text field (6813)
Comment 3 Adele Peterson 2006-03-21 15:10:17 PST
Created attachment 7223 [details]
patch
Comment 4 Darin Adler 2006-03-21 15:47:28 PST
Comment on attachment 7223 [details]
patch

isShadowNode() oughta be const.

_actionInformationForNavigationType should probably pass NO for allowShadowContent.

Places that check isTextNode and call parentNode might result in nil, and then you are calling shadowAncestorNode without a nil check.

Looks great.

r=me