Bug 68125 – [WK2] mouseDidMoveOverElement needs to send more information about hovered element to UiProcess.

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Igor Trindade Oliveira]

mouseDidMoveOverElement needs to send more information about hovered element to UiProcess. Currently when a link is hovered, UiProcess can not know the link url.

[Igor Trindade Oliveira]

Created attachment 107411 [details]
Patch v1

Proposed patch.

[Alexey Proskuryakov]

Could you please provide a rationale in more practical terms? Why does UI process need to know the URL - is it for some functionality similar to status bar?

There is no stable WebKit2 API yet, so anything that didn't come with good rationale is likely to be simply deleted at some point.

[Collabora GTK+ EWS bot]

Comment on attachment 107411 [details]
Patch v1

Attachment 107411 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/9657953

[WebKit Review Bot]

Comment on attachment 107411 [details]
Patch v1

Attachment 107411 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/9686007

[Igor Trindade Oliveira]

In Chrome and Firefox when the user move the mouse over a link in a page the link is showed. It improves the browser usability. Additionally, we from QtWebKit have plans to use this feature, so this code will not be a dead code.

(In reply to comment #2)
> Could you please provide a rationale in more practical terms? Why does UI process need to know the URL - is it for some functionality similar to status bar?
> 
> There is no stable WebKit2 API yet, so anything that didn't come with good rationale is likely to be simply deleted at some point.

[Alexey Proskuryakov]

That looks pretty much like status bar in Safari, which already works in WebKit2, showing the URL. What is the difference between these?

[Anders Carlsson]

(In reply to comment #6)
> That looks pretty much like status bar in Safari, which already works in WebKit2, showing the URL. What is the difference between these?

The way this works in Safari is that we gather the information in the injected bundle and pass it over. I think this way is better because it eases the burden on the WebKit2 client apps.

[Igor Trindade Oliveira]

manually committed r95303: http://trac.webkit.org/changeset/95303

[Anders Carlsson]

I had to revert part of this because it changes the signature of the mouseDidMoveOverElement callback which breaks the ABI and thus WebKit nighties. I'm working on a fix.

[Anders Carlsson]

Fix landed in r95315: <http://trac.webkit.org/changeset/95315> and everything should be back to normal!

[Mark Rowe (bdash)]

This change started installing source and header files in to the WebKit2 framework.  Please be more careful when making Xcode project changes in the future!