Bug 68118 - DFG should not speculate that the child of LogicalNot is a boolean if predictions tell us otherwise
Summary: DFG should not speculate that the child of LogicalNot is a boolean if predict...
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-14 14:16 PDT by Filip Pizlo
Modified: 2011-12-21 14:34 PST (History)
1 user (show)

See Also:


Attachments
the patch (6.32 KB, patch)
2011-09-14 14:17 PDT, Filip Pizlo
fpizlo: review-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2011-09-14 14:16:36 PDT
The DFG JIT currently speculates that all LogicalNots always operate over booleans even when they clearly don't.  Value profiling can tell us if the input value is not a boolean, and we should take advantage of this information.
Comment 1 Filip Pizlo 2011-09-14 14:17:49 PDT
Created attachment 107393 [details]
the patch
Comment 2 Geoffrey Garen 2011-09-14 14:22:36 PDT
Comment on attachment 107393 [details]
the patch

r=me
Comment 3 Eric Seidel (no email) 2011-12-21 14:30:14 PST
Attachment 107393 [details] was posted by a committer and has review+, assigning to Filip Pizlo for commit.
Comment 4 Filip Pizlo 2011-12-21 14:34:36 PST
Comment on attachment 107393 [details]
the patch

This patch is stale and has been superseded.