WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED INVALID
68118
DFG should not speculate that the child of LogicalNot is a boolean if predictions tell us otherwise
https://bugs.webkit.org/show_bug.cgi?id=68118
Summary
DFG should not speculate that the child of LogicalNot is a boolean if predict...
Filip Pizlo
Reported
2011-09-14 14:16:36 PDT
The DFG JIT currently speculates that all LogicalNots always operate over booleans even when they clearly don't. Value profiling can tell us if the input value is not a boolean, and we should take advantage of this information.
Attachments
the patch
(6.32 KB, patch)
2011-09-14 14:17 PDT
,
Filip Pizlo
fpizlo
: review-
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Filip Pizlo
Comment 1
2011-09-14 14:17:49 PDT
Created
attachment 107393
[details]
the patch
Geoffrey Garen
Comment 2
2011-09-14 14:22:36 PDT
Comment on
attachment 107393
[details]
the patch r=me
Eric Seidel (no email)
Comment 3
2011-12-21 14:30:14 PST
Attachment 107393
[details]
was posted by a committer and has review+, assigning to Filip Pizlo for commit.
Filip Pizlo
Comment 4
2011-12-21 14:34:36 PST
Comment on
attachment 107393
[details]
the patch This patch is stale and has been superseded.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug