Bug 68117 - convertToLayerCoords on a position: fixed layer should take transforms into account
Summary: convertToLayerCoords on a position: fixed layer should take transforms into a...
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Julien Chaffraix
URL:
Keywords:
Depends on:
Blocks: 31278
  Show dependency tree / graph
 
Reported: 2011-09-14 14:13 PDT by Julien Chaffraix
Modified: 2011-09-15 12:04 PDT (History)
1 user (show)

See Also:

Attachments
Proposed fix 1: Pass true as useTransform and account for our layer's translation to avoid breaking the rest of the code. (28.28 KB, patch)
2011-09-14 14:44 PDT, Julien Chaffraix 		no flags Details | Formatted Diff | Diff
Proposed fix 1.1: Updated bug & ChangeLog. (28.47 KB, patch)
2011-09-14 15:50 PDT, Julien Chaffraix 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Julien Chaffraix 2011-09-14 14:13:27 PDT 
As mentioned in bug 31278, currently convertToLayerCoords is ignoring transforms when calling localToAbsolute which looks wrong.

This bug aims at removing this limitation.
Comment 1 Julien Chaffraix 2011-09-14 14:44:34 PDT 
Created attachment 107396 [details]
Proposed fix 1: Pass true as useTransform and account for our layer's translation to avoid breaking the rest of the code.
Comment 2 Simon Fraser (smfr) 2011-09-14 14:50:56 PDT 
Comment on attachment 107396 [details]
Proposed fix 1: Pass true as useTransform and account for our layer's translation to avoid breaking the rest of the code.

Looks like this patch only affects position:fixed elements. The bug title and change log should be updated to reflect this.
Comment 3 Julien Chaffraix 2011-09-14 15:50:50 PDT 
Created attachment 107414 [details]
Proposed fix 1.1: Updated bug & ChangeLog.
Comment 4 Julien Chaffraix 2011-09-15 12:04:10 PDT 
Comment on attachment 107414 [details]
Proposed fix 1.1: Updated bug & ChangeLog.

Let's forget about this patch, the scope is not right: my understanding is that the rest of the code is still assuming that transforms are not taken into account in convertToLayer and it seems fragile to just patch one code path.