Bug 68114 - [Qt] Replace QT_GCC_X as they don't exist in Qt5 anymore.
Summary: [Qt] Replace QT_GCC_X as they don't exist in Qt5 anymore.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Alexis Menard (darktears)
URL:
Keywords: Qt, QtTriaged
Depends on: 68180
Blocks:
  Show dependency treegraph
 
Reported: 2011-09-14 14:03 PDT by Alexis Menard (darktears)
Modified: 2011-09-15 12:19 PDT (History)
5 users (show)

See Also:


Attachments
Patch (3.79 KB, patch)
2011-09-14 14:13 PDT, Alexis Menard (darktears)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexis Menard (darktears) 2011-09-14 14:03:47 PDT
[Qt] Replace QT_GCC_X as they don't exist in Qt5 anymore.
Comment 1 Alexis Menard (darktears) 2011-09-14 14:13:44 PDT
Created attachment 107392 [details]
Patch
Comment 2 Kenneth Rohde Christiansen 2011-09-14 14:54:30 PDT
Comment on attachment 107392 [details]
Patch

Ok, I trust you on this one
Comment 3 WebKit Review Bot 2011-09-14 21:32:23 PDT
Comment on attachment 107392 [details]
Patch

Clearing flags on attachment: 107392

Committed r95163: <http://trac.webkit.org/changeset/95163>
Comment 4 WebKit Review Bot 2011-09-14 21:32:28 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Simon Hausmann 2011-09-15 03:24:46 PDT
Comment on attachment 107392 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=107392&action=review

> ChangeLog:3
> +        [Qt] Replace QT_GCC_X as they don't exist in Qt5 anymore.

Hang on, I think this was a mistake. Commit 7493ee1c44a16dc3b155a5bf3ed7ca966a71072a in qtbase accidentally removed
these qmake variables.

> Source/WebKit.pri:99
> +    GCC_VERSION = $$system(gcc -dumpversion)
> +    GCC_VERSION = $$split(GCC_VERSION, ".")

This seems wrong to me in the context of cross compilation.
Comment 6 Simon Hausmann 2011-09-15 03:32:39 PDT
I submitted http://paste.ubuntu.com/689876/ for review and inclusion into qtbase. Once that change is in, then I think we should back out r95163.
Comment 7 Alexis Menard (darktears) 2011-09-15 05:08:27 PDT
(In reply to comment #6)
> I submitted http://paste.ubuntu.com/689876/ for review and inclusion into qtbase. Once that change is in, then I think we should back out r95163.

I tried to get brad with no success. Btw his patch was submitted reviewed by himself :D.

Still it is semantically wrong, QT_GCC_X tells you which compiler version Qt was built, not the one you are actually building.

I haven't though about the context of cross compilation can we get the compiler path in qmake? I mean the one that will be used to compile so I can invoke that variable rather than "gcc"?
Comment 8 Simon Hausmann 2011-09-15 05:27:28 PDT
(In reply to comment #7)
> (In reply to comment #6)
> > I submitted http://paste.ubuntu.com/689876/ for review and inclusion into qtbase. Once that change is in, then I think we should back out r95163.
> 
> I tried to get brad with no success. Btw his patch was submitted reviewed by himself :D.
> 
> Still it is semantically wrong, QT_GCC_X tells you which compiler version Qt was built, not the one you are actually building.

I think it is correct, because qmake doesn't really support using one compiler for Qt and another one for apps. There's only host compilers for some host tools in Qt and then _the_ target compiler.

Differently put: I don't think we should bother about any other setups :)

> I haven't though about the context of cross compilation can we get the compiler path in qmake? I mean the one that will be used to compile so I can invoke that variable rather than "gcc"?

QMAKE_CC and QMAKE_CXX would be correct. But you'd have to duplicate what configure is doing (check if it's gcc, distinguish between major and minor releases in the output). Is it really worth it? :)
Comment 9 Simon Hausmann 2011-09-15 10:55:13 PDT
The Qt fix went in and is now on Gitorious: http://qt.gitorious.org/qt/qtbase/commit/80d406ce39d23ec6c859b9aa427dee8d0d3c9d50