Bug 68110 - committers.py should support multiple IRC nicknames
: committers.py should support multiple IRC nicknames
Status: RESOLVED FIXED
Product: WebKit
Classification: Unclassified
Component: Tools / Tests
: 528+ (Nightly build)
: Unspecified Unspecified
: P2 Normal
Assigned To: Ryosuke Niwa
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-09-14 13:24 PDT by Ryosuke Niwa
Modified: 2011-09-14 13:57 PDT (History)
4 users (show)

See Also:


Attachments
Patch (9.72 KB, patch)
2011-09-14 13:28 PDT, Ryosuke Niwa
eric: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2011-09-14 13:24:09 PDT
Some people list multiple IRC nicknames in http://trac.webkit.org/wiki/WebKit%20Team or ones that don't match with ones they listed in committers.py.  We should support multiple IRC nicknames.
Comment 1 Ryosuke Niwa 2011-09-14 13:28:14 PDT
Created attachment 107385 [details]
Patch
Comment 2 Eric Seidel 2011-09-14 13:33:52 PDT
Comment on attachment 107385 [details]
Patch

OK.  Do we need a .irc_nickname() accessor for the first one?
Comment 3 Ryosuke Niwa 2011-09-14 13:34:46 PDT
(In reply to comment #2)
> (From update of attachment 107385 [details])
> OK.  Do we need a .irc_nickname() accessor for the first one?

I've modified all call sites (only sheriffbot uses it) to support multiple nicknames.
Comment 4 Ryosuke Niwa 2011-09-14 13:57:43 PDT
Committed r95118: <http://trac.webkit.org/changeset/95118>