Bug 68107 - [Chromium] Make WEB_AUDIO conditional and fix the build when disabled
Summary: [Chromium] Make WEB_AUDIO conditional and fix the build when disabled
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Audio (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Peter Beverloo
Depends on:
Blocks: 66689
  Show dependency treegraph
Reported: 2011-09-14 12:47 PDT by Peter Beverloo
Modified: 2011-09-14 21:15 PDT (History)
4 users (show)

See Also:

Patch (3.45 KB, patch)
2011-09-14 12:50 PDT, Peter Beverloo
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Peter Beverloo 2011-09-14 12:47:47 PDT
This patch makes the ENABLE_WEB_AUDIO conditional, and fixes the build when it's disabled.  Some code in the WebMediaPlayerClientImpl relied on it being enabled.
Comment 1 Peter Beverloo 2011-09-14 12:50:24 PDT
Created attachment 107379 [details]
Comment 2 Chris Rogers 2011-09-14 13:02:54 PDT
Hi Peter, this looks fine to me.  Later on we can see what it will take to get this working, but it's normal to disable it at this point.
Comment 3 Kenneth Russell 2011-09-14 14:21:38 PDT
Comment on attachment 107379 [details]

Looks fine to me.
Comment 4 WebKit Review Bot 2011-09-14 21:14:57 PDT
Comment on attachment 107379 [details]

Clearing flags on attachment: 107379

Committed r95160: <http://trac.webkit.org/changeset/95160>
Comment 5 WebKit Review Bot 2011-09-14 21:15:01 PDT
All reviewed patches have been landed.  Closing bug.