Bug 68080 - query SystemParametersInfo for GDI font smoothing settings
Summary: query SystemParametersInfo for GDI font smoothing settings
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mike Reed
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-14 08:13 PDT by Mike Reed
Modified: 2011-09-14 10:03 PDT (History)
4 users (show)

See Also:


Attachments
Patch (3.23 KB, patch)
2011-09-14 08:16 PDT, Mike Reed
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Reed 2011-09-14 08:13:43 PDT
query SystemParametersInfo for GDI font smoothing settings
Comment 1 Mike Reed 2011-09-14 08:16:07 PDT
Created attachment 107332 [details]
Patch
Comment 2 Stephen White 2011-09-14 08:58:17 PDT
Comment on attachment 107332 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=107332&action=review

Looks good.  r=me

> Source/WebCore/platform/graphics/skia/SkiaFontWin.cpp:108
> +    static bool gInited;
> +    static uint32_t gFlags;

Nit:  since gFlags is a function-level static anyway, if you wanted, you could save the gInited bool by refactoring the initialization into another function and doing:

static uint32_t gFlags = getTextFlagsFromGDI();
return gFlags;

Of course, a new function to save a bool, maybe not worth it.  :)
Comment 3 WebKit Review Bot 2011-09-14 10:03:19 PDT
Comment on attachment 107332 [details]
Patch

Clearing flags on attachment: 107332

Committed r95097: <http://trac.webkit.org/changeset/95097>
Comment 4 WebKit Review Bot 2011-09-14 10:03:23 PDT
All reviewed patches have been landed.  Closing bug.