Bug 68078 - [chromium] compilation failed in target 'webkit_unit_tests'
Summary: [chromium] compilation failed in target 'webkit_unit_tests'
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-14 06:51 PDT by chandra shekar vallala
Modified: 2011-09-16 15:26 PDT (History)
3 users (show)

See Also:


Attachments
fix for the bug. (1.20 KB, text/plain)
2011-09-14 07:02 PDT, chandra shekar vallala
abarth: review-
Details
updated the patch (1.17 KB, patch)
2011-09-14 23:52 PDT, chandra shekar vallala
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description chandra shekar vallala 2011-09-14 06:51:04 PDT
c1plus: warnings being treated as errors
third_party/WebKit/Source/WebKit/chromium/tests/WebFrameTest.cpp: In member function ‘virtual WebKit::WebNavigationPolicy<unnamed>::TestReloadDoesntRedirectWebFrameClient::decidePolicyForNavigation(WebKit::WebFrame*, const WebKit::WebURLRequest&, WebKit::WebNavigationType, const WebKit::WebNode&, WebKit::WebNavigationPolicy, bool)’:
third_party/WebKit/Source/WebKit/chromium/tests/WebFrameTest.cpp:226:9: error: converting ‘false’ to pointer type for argument 1 of ‘char testing::internal::IsNullLiteralHelper(testing::internal::Secret*)’
make: * [out/Debug/obj.target/webkit_unit_tests/third_party/WebKit/Source/WebKit/chromium/tests/WebFrameTest.o] Error 1
Comment 1 chandra shekar vallala 2011-09-14 07:02:36 PDT
Created attachment 107328 [details]
fix for the bug.
Comment 2 Adam Barth 2011-09-14 11:48:29 PDT
Comment on attachment 107328 [details]
fix for the bug.

View in context: https://bugs.webkit.org/attachment.cgi?id=107328&action=review

> Source/WebKit/chromium/tests/WebFrameTest.cpp:226
> -        EXPECT_EQ(false, isRedirect);
> +        EXPECT_EQ(0, isRedirect);

This should be EXPECT_FALSE
Comment 3 chandra shekar vallala 2011-09-14 23:52:50 PDT
Created attachment 107467 [details]
updated the patch

Updated the patch as per comments.
Comment 4 WebKit Review Bot 2011-09-16 15:26:35 PDT
Comment on attachment 107467 [details]
updated the patch

Clearing flags on attachment: 107467

Committed r95328: <http://trac.webkit.org/changeset/95328>
Comment 5 WebKit Review Bot 2011-09-16 15:26:39 PDT
All reviewed patches have been landed.  Closing bug.