RESOLVED FIXED68078
[chromium] compilation failed in target 'webkit_unit_tests' 
https://bugs.webkit.org/show_bug.cgi?id=68078
Summary [chromium] compilation failed in target 'webkit_unit_tests'
chandra shekar vallala
Reported 2011-09-14 06:51:04 PDT
c1plus: warnings being treated as errors third_party/WebKit/Source/WebKit/chromium/tests/WebFrameTest.cpp: In member function ‘virtual WebKit::WebNavigationPolicy<unnamed>::TestReloadDoesntRedirectWebFrameClient::decidePolicyForNavigation(WebKit::WebFrame*, const WebKit::WebURLRequest&, WebKit::WebNavigationType, const WebKit::WebNode&, WebKit::WebNavigationPolicy, bool)’: third_party/WebKit/Source/WebKit/chromium/tests/WebFrameTest.cpp:226:9: error: converting ‘false’ to pointer type for argument 1 of ‘char testing::internal::IsNullLiteralHelper(testing::internal::Secret*)’ make: * [out/Debug/obj.target/webkit_unit_tests/third_party/WebKit/Source/WebKit/chromium/tests/WebFrameTest.o] Error 1
Attachments
fix for the bug. (1.20 KB, text/plain)
2011-09-14 07:02 PDT, chandra shekar vallala 		abarth: review-
Details
updated the patch (1.17 KB, patch)
2011-09-14 23:52 PDT, chandra shekar vallala 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
chandra shekar vallala
Comment 1 2011-09-14 07:02:36 PDT
Created attachment 107328 [details] fix for the bug.
Adam Barth
Comment 2 2011-09-14 11:48:29 PDT
Comment on attachment 107328 [details] fix for the bug. View in context: https://bugs.webkit.org/attachment.cgi?id=107328&action=review > Source/WebKit/chromium/tests/WebFrameTest.cpp:226 > - EXPECT_EQ(false, isRedirect); > + EXPECT_EQ(0, isRedirect); This should be EXPECT_FALSE
chandra shekar vallala
Comment 3 2011-09-14 23:52:50 PDT
Created attachment 107467 [details] updated the patch Updated the patch as per comments.
WebKit Review Bot
Comment 4 2011-09-16 15:26:35 PDT
Comment on attachment 107467 [details] updated the patch Clearing flags on attachment: 107467 Committed r95328: <http://trac.webkit.org/changeset/95328>
WebKit Review Bot
Comment 5 2011-09-16 15:26:39 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.