Bug 68067 - Implement a PageTransitionEvent constructor for V8
Summary: Implement a PageTransitionEvent constructor for V8
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kentaro Hara
Depends on:
Blocks: 67824
  Show dependency treegraph
Reported: 2011-09-14 01:41 PDT by Kentaro Hara
Modified: 2011-10-11 18:24 PDT (History)
5 users (show)

See Also:

Patch (4.40 KB, patch)
2011-09-14 03:43 PDT, Kentaro Hara
abarth: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
patch for commit (4.35 KB, patch)
2011-09-27 18:19 PDT, Kentaro Hara
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kentaro Hara 2011-09-14 01:41:13 PDT
We have been working on implementing constructors of Events. PageTransitionEvent has a constructor in JSC (https://bugs.webkit.org/show_bug.cgi?id=68048), but do not have it in V8.
Comment 1 Kentaro Hara 2011-09-14 03:43:07 PDT
Created attachment 107316 [details]
Comment 2 WebKit Review Bot 2011-09-27 08:59:47 PDT
Comment on attachment 107316 [details]

Rejecting attachment 107316 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
eded at 1 with fuzz 3.
patching file Source/WebCore/bindings/v8/custom/V8EventConstructors.cpp
Hunk #1 succeeded at 37 (offset 1 line).
Hunk #2 succeeded at 50 (offset 2 lines).
Hunk #3 FAILED at 110.
1 out of 3 hunks FAILED -- saving rejects to file Source/WebCore/bindings/v8/custom/V8EventConstructors.cpp.rej
patching file Source/WebCore/dom/PageTransitionEvent.idl

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Adam Barth', u'--force']" exit_code: 1

Full output: http://queues.webkit.org/results/9882333
Comment 3 Kentaro Hara 2011-09-27 18:19:13 PDT
Created attachment 108945 [details]
patch for commit
Comment 4 WebKit Review Bot 2011-09-27 19:29:34 PDT
Comment on attachment 108945 [details]
patch for commit

Clearing flags on attachment: 108945

Committed r96180: <http://trac.webkit.org/changeset/96180>