Bug 68059 - committers.py is missing some contributors
Summary: committers.py is missing some contributors
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks: 68045
  Show dependency treegraph
 
Reported: 2011-09-13 23:39 PDT by Ryosuke Niwa
Modified: 2011-09-14 10:15 PDT (History)
9 users (show)

See Also:


Attachments
updates committers.py (3.26 KB, patch)
2011-09-13 23:41 PDT, Ryosuke Niwa
no flags Details | Formatted Diff | Diff
updates committers.py (4.63 KB, patch)
2011-09-13 23:51 PDT, Ryosuke Niwa
abarth: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2011-09-13 23:39:47 PDT
While working on the bug 68045, I found that it's missing some contributors that are listed on http://trac.webkit.org/wiki/WebKit%20Team
Comment 1 Ryosuke Niwa 2011-09-13 23:41:53 PDT
Created attachment 107294 [details]
updates committers.py
Comment 2 Ryosuke Niwa 2011-09-13 23:48:30 PDT
Comment on attachment 107294 [details]
updates committers.py

More stuff to add :(
Comment 3 Ryosuke Niwa 2011-09-13 23:51:45 PDT
Created attachment 107295 [details]
updates committers.py
Comment 4 Ryosuke Niwa 2011-09-13 23:56:23 PDT
Thanks for the review!
Comment 5 Ryosuke Niwa 2011-09-13 23:57:10 PDT
Committed r95078: <http://trac.webkit.org/changeset/95078>
Comment 6 Eric Seidel (no email) 2011-09-13 23:59:28 PDT
Comment on attachment 107295 [details]
updates committers.py

View in context: https://bugs.webkit.org/attachment.cgi?id=107295&action=review

> Tools/Scripts/webkitpy/common/config/committers.py:229
> +    Committer(u"Kim Gr\u00f6nholm", "kim.1.gronholm@nokia.com"),

Do we know that these people actually became committers and weren't just invited?
Comment 7 Eric Seidel (no email) 2011-09-14 00:00:32 PDT
Comment on attachment 107295 [details]
updates committers.py

View in context: https://bugs.webkit.org/attachment.cgi?id=107295&action=review

> Tools/Scripts/webkitpy/common/config/committers.py:200
> +    Committer("Jan Erik Hanssen", "jhanssen@sencha.com", "jehanssen"),

Normally folks add themselves to the committers file, that makes it easy to tell that their actually committers.  The validate-committer-list script in Tools/Scripts can of course compare with the git/svn history and validate thsi for us of course.
Comment 8 Ryosuke Niwa 2011-09-14 00:04:05 PDT
(In reply to comment #7)
> Normally folks add themselves to the committers file, that makes it easy to tell that their actually committers.  The validate-committer-list script in Tools/Scripts can of course compare with the git/svn history and validate thsi for us of course.

I've manually looked through trac to make sure they've committed something in the past :)
Comment 9 Alexey Proskuryakov 2011-09-14 09:05:46 PDT
Could you please post a link to a trac entry for a Jan Erik's commit? I cannot find one.
Comment 10 Ryosuke Niwa 2011-09-14 10:14:14 PDT
(In reply to comment #9)
> Could you please post a link to a trac entry for a Jan Erik's commit? I cannot find one.

You're right, he has been invited to committers but hasn't made any manual commits yet.  I'm removing him from the list for now.
Comment 11 Ryosuke Niwa 2011-09-14 10:15:46 PDT
Done in http://trac.webkit.org/changeset/95098.