RESOLVED FIXED Bug 68059
committers.py is missing some contributors 
https://bugs.webkit.org/show_bug.cgi?id=68059
Summary committers.py is missing some contributors
Ryosuke Niwa
Reported 2011-09-13 23:39:47 PDT
While working on the bug 68045, I found that it's missing some contributors that are listed on http://trac.webkit.org/wiki/WebKit%20Team
Attachments
updates committers.py (3.26 KB, patch)
2011-09-13 23:41 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
updates committers.py (4.63 KB, patch)
2011-09-13 23:51 PDT, Ryosuke Niwa 		abarth: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2011-09-13 23:41:53 PDT
Created attachment 107294 [details] updates committers.py
Ryosuke Niwa
Comment 2 2011-09-13 23:48:30 PDT
Comment on attachment 107294 [details] updates committers.py More stuff to add :(
Ryosuke Niwa
Comment 3 2011-09-13 23:51:45 PDT
Created attachment 107295 [details] updates committers.py
Ryosuke Niwa
Comment 4 2011-09-13 23:56:23 PDT
Thanks for the review!
Ryosuke Niwa
Comment 5 2011-09-13 23:57:10 PDT
Committed r95078: <http://trac.webkit.org/changeset/95078>
Eric Seidel (no email)
Comment 6 2011-09-13 23:59:28 PDT
Comment on attachment 107295 [details] updates committers.py View in context: https://bugs.webkit.org/attachment.cgi?id=107295&action=review > Tools/Scripts/webkitpy/common/config/committers.py:229 > + Committer(u"Kim Gr\u00f6nholm", "kim.1.gronholm@nokia.com"), Do we know that these people actually became committers and weren't just invited?
Eric Seidel (no email)
Comment 7 2011-09-14 00:00:32 PDT
Comment on attachment 107295 [details] updates committers.py View in context: https://bugs.webkit.org/attachment.cgi?id=107295&action=review > Tools/Scripts/webkitpy/common/config/committers.py:200 > + Committer("Jan Erik Hanssen", "jhanssen@sencha.com", "jehanssen"), Normally folks add themselves to the committers file, that makes it easy to tell that their actually committers. The validate-committer-list script in Tools/Scripts can of course compare with the git/svn history and validate thsi for us of course.
Ryosuke Niwa
Comment 8 2011-09-14 00:04:05 PDT
(In reply to comment #7) > Normally folks add themselves to the committers file, that makes it easy to tell that their actually committers. The validate-committer-list script in Tools/Scripts can of course compare with the git/svn history and validate thsi for us of course. I've manually looked through trac to make sure they've committed something in the past :)
Alexey Proskuryakov
Comment 9 2011-09-14 09:05:46 PDT
Could you please post a link to a trac entry for a Jan Erik's commit? I cannot find one.
Ryosuke Niwa
Comment 10 2011-09-14 10:14:14 PDT
(In reply to comment #9) > Could you please post a link to a trac entry for a Jan Erik's commit? I cannot find one. You're right, he has been invited to committers but hasn't made any manual commits yet. I'm removing him from the list for now.
Ryosuke Niwa
Comment 11 2011-09-14 10:15:46 PDT
Done in http://trac.webkit.org/changeset/95098.
Note You need to log in before you can comment on or make changes to this bug.