Bug 68056 - MediaPlayerPrivateAVFoundationObjC's "periodic time observer" is unnecessary
Summary: MediaPlayerPrivateAVFoundationObjC's "periodic time observer" is unnecessary
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Macintosh OS X 10.6
: P2 Normal
Assignee: Eric Carlson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2011-09-13 21:42 PDT by Eric Carlson
Modified: 2011-09-14 11:59 PDT (History)
1 user (show)

See Also:


Attachments
Proposed patch. (2.82 KB, patch)
2011-09-13 22:07 PDT, Eric Carlson
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2011-09-13 21:42:45 PDT
MediaPlayerPrivateAVFoundationObjC::createAVPlayer creates a periodic time observer that fires once in a very long while just so it can also be called whenever the time is changed. This was originally necessary early on, but AVPlayerItem's -seekToTime:toleranceBefore:toleranceAfter:completionHandler makes it completely unnecessary.
Comment 1 Radar WebKit Bug Importer 2011-09-13 21:43:37 PDT
<rdar://problem/10121225>
Comment 2 Eric Carlson 2011-09-13 22:07:12 PDT
Created attachment 107286 [details]
Proposed patch.
Comment 3 Darin Adler 2011-09-13 22:14:46 PDT
Comment on attachment 107286 [details]
Proposed patch.

Patch would be better if it explained why we thought it was needed, what changed, and so why it’s not needed now.
Comment 4 Eric Carlson 2011-09-14 11:59:36 PDT
 http://trac.webkit.org/changeset/95104