RESOLVED INVALID 68052
[CMAKE] Change wrong setting variables in FindPango.cmake 
https://bugs.webkit.org/show_bug.cgi?id=68052
Summary [CMAKE] Change wrong setting variables in FindPango.cmake
Gyuyoung Kim
Reported 2011-09-13 20:16:44 PDT
I think FindPango.cmake should have Pango_XXX setting variable instead of Freetype_xxx.
Attachments
Proposed Patch (1.24 KB, patch)
2011-09-13 20:17 PDT, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Modified Patch (1.24 KB, patch)
2011-09-13 20:18 PDT, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Modified Patch (1.24 KB, patch)
2011-09-13 21:51 PDT, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Gyuyoung Kim
Comment 1 2011-09-13 20:17:32 PDT
Created attachment 107277 [details] Proposed Patch
Gyuyoung Kim
Comment 2 2011-09-13 20:18:53 PDT
Created attachment 107278 [details] Modified Patch
Gyuyoung Kim
Comment 3 2011-09-13 20:19:34 PDT
CC'ing Patric and Rafael.
WebKit Review Bot
Comment 4 2011-09-13 20:20:36 PDT
Attachment 107277 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'ChangeLog', u'Source/cmake/FindPango.cmake']" exit_code: 1 ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Review Bot
Comment 5 2011-09-13 20:21:44 PDT
Attachment 107278 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'ChangeLog', u'Source/cmake/FindPango.cmake']" exit_code: 1 ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Ryuan Choi
Comment 6 2011-09-13 20:29:41 PDT
Comment on attachment 107278 [details] Modified Patch View in context: https://bugs.webkit.org/attachment.cgi?id=107278&action=review > ChangeLog:4 > + https://bugs.webkit.org/show_bug.cgi?id=xxxx It's because of xxxx
Gyuyoung Kim
Comment 7 2011-09-13 21:51:35 PDT
Created attachment 107283 [details] Modified Patch Oops. I fix it.
Raphael Kubo da Costa (:rakuco)
Comment 8 2011-09-14 06:59:59 PDT
I don't really understand this patch. Pango depends on Freetype, and line 11 actually looks for Freetype. Where are Pango_INCLUDE_DIRS and Pango_LIBRARIES set?
Gyuyoung Kim
Comment 9 2011-09-15 01:06:29 PDT
(In reply to comment #8) > I don't really understand this patch. Pango depends on Freetype, and line 11 actually looks for Freetype. Where are Pango_INCLUDE_DIRS and Pango_LIBRARIES set? Ah, I'm really sorry. There was misunderstanding. I will pay careful attention to submit patch further.
Note You need to log in before you can comment on or make changes to this bug.