Bug 68050 – Layout Test fast/css/transformed-mask.html, fast/reflections/reflection-masks.html are failing

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Fumitoshi Ukai]

The following layout test are failing on chromium.

fast/css/transformed-mask.html
fast/reflections/reflection-masks.html
fast/css/getComputedStyle/computed-style-with-zoom.html

Probable cause:
http://trac.webkit.org/changeset/95058/

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=fast%2Fcss%2Ftransformed-mask.html%2Cfast%2Freflections%2Freflection-masks.html%2Cfast%2Fcss%2FgetComputedStyle%2Fcomputed-style-with-zoom.html&showExpectations=true

failed to apply reflection mask?
in computed-style-with-zoom.html,actual results lost "fill"

--- e:\b\build\slave\Webkit_Vista\build\layout-test-results\fast/css/getComputedStyle/computed-style-with-zoom-expected.txt 
+++ e:\b\build\slave\Webkit_Vista\build\layout-test-results\fast/css/getComputedStyle/computed-style-with-zoom-actual.txt 
@@ -5,7 +5,7 @@
 
 PASS -webkit-border-horizontal-spacing, value: "20px"
 PASS -webkit-border-vertical-spacing, value: "20px"
-PASS -webkit-box-reflect, value: "below 20px -webkit-gradient(linear, 0% 0%, 0% 100%, from(transparent), to(white)) 0 fill / auto / 0px stretch"
+PASS -webkit-box-reflect, value: "below 20px -webkit-gradient(linear, 0% 0%, 0% 100%, from(transparent), to(white)) 0 / auto / 0px stretch"
 PASS -webkit-box-shadow, value: "rgb(255, 0, 0) 20px 20px 20px 20px"
 PASS -webkit-column-rule-width, value: "20px"
 PASS -webkit-perspective-origin, value: "20px 20px"

[Fumitoshi Ukai]

compositing/reflections/masked-reflection-on-composited.html is also failing on GPU.

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20GPU%20Mesa%20-%20chromium.org&showExpectations=true&tests=compositing%2Freflections%2Fmasked-reflection-on-composited.html

[Dave Hyatt]

Ok will look.

[Dave Hyatt]

I know what caused this. Patch coming shortly.

[Dave Hyatt]

Created attachment 107290 [details]
Patch

[WebKit Review Bot]

Comment on attachment 107290 [details]
Patch

Attachment 107290 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/9659454

New failing tests:
svg/css/getComputedStyle-basic.xhtml
fast/css/getComputedStyle/computed-style.html
fast/css/getComputedStyle/computed-style-without-renderer.html

[Dave Hyatt]

Created attachment 107340 [details]
Patch

[Dave Hyatt]

Created attachment 107341 [details]
Patch

[Adam Roben (:aroben)]

Comment on attachment 107341 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=107341&action=review

> Source/WebCore/css/CSSStyleSelector.cpp:3317
>          NinePieceImage mask;
> -        mask.setImageSlices(LengthBox(0)); // For backwards compatibility, just make the mask box image slices 0 instead of 100%.
> -        mask.setBorderSlices(LengthBox()); // The slices default to auto.
> +        mask.setMaskDefaults();

Maybe it would be better to have a separate NinePieceImage constructor that did this for you?

[Dave Hyatt]

Fixed in r95096.