WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
68047
OS(QNX) builds with threads turned off
https://bugs.webkit.org/show_bug.cgi?id=68047
Summary
OS(QNX) builds with threads turned off
Geoffrey Garen
Reported
2011-09-13 18:20:14 PDT
Per email to webkit-dev, we're going to remove the "no threads" #ifdefs from JavaScriptCore and WebKit. Please update the OS(QNX) platform to be compatible with this change. Try this, in Platform.h: Unconditionally set ENABLE_SINGLE_THREADED=0. Unconditionally set ENABLE_JSC_MULTIPLE_THREADS=1. Unconditionally set ENABLE_WTF_MULTIPLE_THREADS=1. Build and see what happens.
Attachments
Patch
(4.40 KB, patch)
2011-09-14 11:43 PDT
,
Eli Fidler
no flags
Details
Formatted Diff
Diff
Patch
(3.46 KB, patch)
2011-09-19 14:05 PDT
,
Eli Fidler
no flags
Details
Formatted Diff
Diff
Patch
(3.93 KB, patch)
2011-09-19 15:47 PDT
,
Eli Fidler
no flags
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
Eli Fidler
Comment 1
2011-09-14 11:43:34 PDT
Created
attachment 107364
[details]
Patch
WebKit Review Bot
Comment 2
2011-09-15 08:47:42 PDT
Comment on
attachment 107364
[details]
Patch Rejecting
attachment 107364
[details]
from commit-queue.
efidler@rim.com
does not have committer permissions according to
http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py
. - If you do not have committer rights please read
http://webkit.org/coding/contributing.html
for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights.
WebKit Review Bot
Comment 3
2011-09-15 09:48:18 PDT
Comment on
attachment 107364
[details]
Patch Rejecting
attachment 107364
[details]
from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: k #4 succeeded at 367 with fuzz 1. Hunk #5 FAILED at 429. Hunk #6 succeeded at 453 (offset 10 lines). 1 out of 6 hunks FAILED -- saving rejects to file Source/JavaScriptCore/heap/MachineStackMarker.cpp.rej patching file Source/JavaScriptCore/wtf/Platform.h Hunk #1 FAILED at 588. 1 out of 1 hunk FAILED -- saving rejects to file Source/JavaScriptCore/wtf/Platform.h.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Sam Weinig', u'--force']" exit_code: 1 Full output:
http://queues.webkit.org/results/9694068
Antonio Gomes
Comment 4
2011-09-15 09:49:24 PDT
(In reply to
comment #2
)
> (From update of
attachment 107364
[details]
) > Rejecting
attachment 107364
[details]
from commit-queue. > >
efidler@rim.com
does not have committer permissions according to
http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py
. > > - If you do not have committer rights please read
http://webkit.org/coding/contributing.html
for instructions on how to use bugzilla flags. > > - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights.
Eli, we can easily fix it. Upload a patch that adds your @rim.com email to committers.py, and cq? it. I can cq+ and you will be able to cq+ patches yourself.
> Last 500 characters of output: > k #4 succeeded at 367 with fuzz 1. > Hunk #5 FAILED at 429. > Hunk #6 succeeded at 453 (offset 10 lines). > 1 out of 6 hunks FAILED -- saving rejects to file Source/JavaScriptCore/heap/MachineStackMarker.cpp.rej > patching file Source/JavaScriptCore/wtf/Platform.h > Hunk #1 FAILED at 588. > 1 out of 1 hunk FAILED -- saving rejects to file Source/JavaScriptCore/wtf/Platform.h.rej > > Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Sam Weinig', u'--force']" exit_code: 1 > > Full output:
http://queues.webkit.org/results/9694068
btw, you patch does not apply to trunk clearly it seems.
Eli Fidler
Comment 5
2011-09-15 10:44:49 PDT
I'll rebase the patch.
Eli Fidler
Comment 6
2011-09-19 14:05:45 PDT
Created
attachment 107917
[details]
Patch
Geoffrey Garen
Comment 7
2011-09-19 14:29:13 PDT
Comment on
attachment 107917
[details]
Patch This patch doesn't seem to turn on threads for QNX. How did you test it?
Eli Fidler
Comment 8
2011-09-19 15:35:58 PDT
Your patch in
r94871
enabled JSC_MULTIPLE_THREADS unconditionally, so our build is broken without this patch. There's no OS(QNX) build system upstream yet, so you probably couldn't know this.
Eli Fidler
Comment 9
2011-09-19 15:47:28 PDT
Created
attachment 107935
[details]
Patch
Daniel Bates
Comment 10
2011-09-19 15:49:58 PDT
Comment on
attachment 107935
[details]
Patch This patch now enables PThread support on QNX. r=me
WebKit Review Bot
Comment 11
2011-09-19 17:34:46 PDT
Comment on
attachment 107935
[details]
Patch Clearing flags on attachment: 107935 Committed
r95498
: <
http://trac.webkit.org/changeset/95498
>
WebKit Review Bot
Comment 12
2011-09-19 17:34:51 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug