Bug 68034 – Update media-controls.js so it can find the timeline slider

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Eric Carlson]

The mediaControlsButtonCoordinates() function in LayoutTests/media/media-controls.js returns the center point of an element in the media controller so it is possible to write cross-platform tests that use the controls. It doesn't work with the timeline slider or volume slider because it assumes that all of the elements in the controller are siblings.

[Eric Carlson]

Created attachment 107239 [details]
Proposed patch.

[Darin Adler]

Comment on attachment 107239 [details]
Proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=107239&action=review

r=me -- this code seems like it will work but there are some things worth fixing

> LayoutTests/media/media-controls.js:2
> +function mediaConrolsElement(parent, id)

Typo here: "conrols".

Not sure that naming this argument “parent” is good; the code iterates the siblings of what’s passed in, not its children.

> LayoutTests/media/media-controls.js:5
> +    if (parent.nodeType !== Node.ELEMENT_NODE)
> +        return null;

I don’t think this is needed. Not sure why you are checking the type of the first element in a sibling list but not the types of the rest. As far as I can tell no checking is needed.

> LayoutTests/media/media-controls.js:7
> +    controlID = "-webkit-media-controls-" + id;

Should use var here.

> LayoutTests/media/media-controls.js:13
> +            var childElement = mediaConrolsElement(element.firstChild, id);

This will work, but there are also non-recursive ways to walk an entire hierarchy.

> LayoutTests/media/media-controls.js:25
> +    var controlsShadow = internals.shadowRoot(element).firstChild.firstChild;

Would be nice to have a why comment here explaining why we are descending two levels deep with firstChild.

[Eric Carlson]

(In reply to comment #2)
> (From update of attachment 107239 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=107239&action=review
> 
> r=me -- this code seems like it will work but there are some things worth fixing
> 
> > LayoutTests/media/media-controls.js:2
> > +function mediaConrolsElement(parent, id)
> 
> Typo here: "conrols".
> 
> Not sure that naming this argument “parent” is good; the code iterates the siblings of what’s passed in, not its children.
> 
  Fixed both, thanks.

> > LayoutTests/media/media-controls.js:5
> > +    if (parent.nodeType !== Node.ELEMENT_NODE)
> > +        return null;
> 
> I don’t think this is needed. Not sure why you are checking the type of the first element in a sibling list but not the types of the rest. As far as I can tell no checking is needed.
> 
  It was there because internals.shadowPseudoId() throws an exception if called for an element that doesn't have a shadow ID and the TEXT_NODE nodes don't, but a better way to deal with that is with a comment and a try block. Fixed.

> > LayoutTests/media/media-controls.js:7
> > +    controlID = "-webkit-media-controls-" + id;
> 
> Should use var here.
> 
  Thanks, fixed.

> > LayoutTests/media/media-controls.js:13
> > +            var childElement = mediaConrolsElement(element.firstChild, id);
> 
> This will work, but there are also non-recursive ways to walk an entire hierarchy.
> 
  The media controls hierarchy is small and shallow, so I left this as is for now.

> > LayoutTests/media/media-controls.js:25
> > +    var controlsShadow = internals.shadowRoot(element).firstChild.firstChild;
> 
> Would be nice to have a why comment here explaining why we are descending two levels deep with firstChild.
>
  Good point, there isn't any reason to hard code it at two levels deep. Fixed.

Thanks!

[Radar WebKit Bug Importer]

<rdar://problem/10120776>

[Eric Carlson]

http://trac.webkit.org/changeset/95111