Bug 68033 - Implement globalFlag for WebKitTestRunner
Summary: Implement globalFlag for WebKitTestRunner
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Macintosh OS X 10.7
: P2 Enhancement
Assignee: Jon Lee
URL:
Keywords: InRadar
Depends on:
Blocks: 68091 28633
  Show dependency treegraph
 
Reported: 2011-09-13 14:55 PDT by Jon Lee
Modified: 2011-09-14 11:59 PDT (History)
4 users (show)

See Also:


Attachments
Patch (2.41 KB, patch)
2011-09-13 15:50 PDT, Jon Lee
no flags Details | Formatted Diff | Diff
Patch (3.19 KB, patch)
2011-09-14 11:01 PDT, Jon Lee
sam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jon Lee 2011-09-13 14:55:44 PDT
layoutTestController should have globalFlag like DumpRenderTree
Comment 1 Jon Lee 2011-09-13 15:23:17 PDT
<rdar://problem/10119204>
Comment 2 Jon Lee 2011-09-13 15:50:24 PDT
Created attachment 107247 [details]
Patch
Comment 3 Simon Fraser (smfr) 2011-09-13 16:03:53 PDT
What the heck is globalFlag? Can it have a better name?
Comment 4 Jon Lee 2011-09-13 16:05:07 PDT
It's a flag that's globally accessible across all windows.

It existed in DRT (grep for globalFlag in the layout tests).
Comment 5 Darin Adler 2011-09-13 16:19:57 PDT
Comment on attachment 107247 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=107247&action=review

This is OK. But it would be best to also include the patches that can be removed from the Skipped list.

> Tools/WebKitTestRunner/InjectedBundle/LayoutTestController.h:205
> +    bool m_globalFlag;

Need to initialize m_globalFlag in the constructor instead of letting it have a random uninitialized value at first. Also probably need to reset it in between tests.
Comment 6 Jon Lee 2011-09-13 16:32:04 PDT
(In reply to comment #5)
> This is OK. But it would be best to also include the patches that can be removed from the Skipped list.

I will comb through the list and upload a new patch.

> Need to initialize m_globalFlag in the constructor instead of letting it have a random uninitialized value at first.

Done

> Also probably need to reset it in between tests.

If I'm reading the code correctly I believe a new layout test controller is created for each test.
Comment 7 Jon Lee 2011-09-14 11:01:48 PDT
Created attachment 107357 [details]
Patch
Comment 8 Jon Lee 2011-09-14 11:05:34 PDT
To expedite the patch, I've decided to instead add a new task to enable the tests that use globalFlag.
Comment 9 Jon Lee 2011-09-14 11:59:57 PDT
Committed r95109: <http://trac.webkit.org/changeset/95109>