layoutTestController should have globalFlag like DumpRenderTree
<rdar://problem/10119204>
Created attachment 107247 [details] Patch
What the heck is globalFlag? Can it have a better name?
It's a flag that's globally accessible across all windows. It existed in DRT (grep for globalFlag in the layout tests).
Comment on attachment 107247 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=107247&action=review This is OK. But it would be best to also include the patches that can be removed from the Skipped list. > Tools/WebKitTestRunner/InjectedBundle/LayoutTestController.h:205 > + bool m_globalFlag; Need to initialize m_globalFlag in the constructor instead of letting it have a random uninitialized value at first. Also probably need to reset it in between tests.
(In reply to comment #5) > This is OK. But it would be best to also include the patches that can be removed from the Skipped list. I will comb through the list and upload a new patch. > Need to initialize m_globalFlag in the constructor instead of letting it have a random uninitialized value at first. Done > Also probably need to reset it in between tests. If I'm reading the code correctly I believe a new layout test controller is created for each test.
Created attachment 107357 [details] Patch
To expedite the patch, I've decided to instead add a new task to enable the tests that use globalFlag.
Committed r95109: <http://trac.webkit.org/changeset/95109>