Bug 68029 - [chromium] fix flakiness dashboard for chromium interactive tests
Summary: [chromium] fix flakiness dashboard for chromium interactive tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ojan Vafai
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-13 14:29 PDT by Ojan Vafai
Modified: 2011-09-13 14:49 PDT (History)
1 user (show)

See Also:


Attachments
Patch (2.29 KB, patch)
2011-09-13 14:29 PDT, Ojan Vafai
tony: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ojan Vafai 2011-09-13 14:29:27 PDT
[chromium] fix flakiness dashboard for chromium interactive tests
Comment 1 Ojan Vafai 2011-09-13 14:29:54 PDT
Created attachment 107228 [details]
Patch
Comment 2 Tony Chang 2011-09-13 14:35:24 PDT
Comment on attachment 107228 [details]
Patch

rs=me
Comment 3 Tony Chang 2011-09-13 14:35:43 PDT
Comment on attachment 107228 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=107228&action=review

> Tools/TestResultServer/static-dashboards/flakiness_dashboard.html:545
>  }

Should there be an assert or something if we get here?
Comment 4 Ojan Vafai 2011-09-13 14:40:42 PDT
(In reply to comment #3)
> (From update of attachment 107228 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=107228&action=review
> 
> > Tools/TestResultServer/static-dashboards/flakiness_dashboard.html:545
> >  }
> 
> Should there be an assert or something if we get here?

The caller asserts.
Comment 5 Ojan Vafai 2011-09-13 14:49:02 PDT
Committed r95046: <http://trac.webkit.org/changeset/95046>