Bug 68025 - Move identifier filter from CSSStyleSelector to SelectorChecker
Summary: Move identifier filter from CSSStyleSelector to SelectorChecker
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2011-09-13 14:20 PDT by Antti Koivisto
Modified: 2011-09-13 15:38 PDT (History)
4 users (show)

See Also:

patch (20.77 KB, patch)
2011-09-13 14:34 PDT, Antti Koivisto
sam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2011-09-13 14:20:37 PDT
This is a more logical place for this code (and also makes CSSStyleSelector slightly less bloated). It will make it possible to use fastRejectSelector for querySelectoAll in the future.
Comment 1 Antti Koivisto 2011-09-13 14:34:00 PDT
Created attachment 107230 [details]
Comment 2 WebKit Review Bot 2011-09-13 14:36:29 PDT
Attachment 107230 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/css/SelectorChecker.h:63:  The parameter name "selector" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/css/SelectorChecker.cpp:186:  A case label should not be indented, but line up with its switch statement.  [whitespace/indent] [4]
Total errors found: 2 in 5 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Antti Koivisto 2011-09-13 15:38:36 PDT