Bug 68020 - diff-based tools (check-webkit-style, prettypatch, etc.) get confused by git line-ending output
Summary: diff-based tools (check-webkit-style, prettypatch, etc.) get confused by git ...
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-13 12:26 PDT by Eric Seidel (no email)
Modified: 2023-04-27 12:58 PDT (History)
6 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2011-09-13 12:26:47 PDT 
ERROR: Unexpected diff format when parsing a chunk: 'The file will have its original line endings in your working directory.'
ERROR: Unexpected diff format when parsing a chunk: 'warning: LF will be replaced by CRLF in WebKitLibraries/win/tools/vsprops/FeatureDefinesCairo.vsprops.'
ERROR: Unexpected diff format when parsing a chunk: 'The file will have its original line endings in your working directory.'
ERROR: Unexpected diff format when parsing a chunk: 'XHTMLMP) $(ENABLE_XPATH) $(ENABLE_XSLT);'
Comment 1 Eric Seidel (no email) 2011-09-13 12:29:33 PDT 
You can see this output appear in review-patch too:
https://bugs.webkit.org/attachment.cgi?id=107210&action=review
https://bugs.webkit.org/attachment.cgi?id=107207&action=review
Comment 2 Tom Zakrajsek 2011-09-13 13:23:46 PDT 
Might be fixed locally by git config --global core.autocrlf true.  I'm looking to see if there is a param we can specify for same.