Bug 68013 - Update GYP file to use new scripts in GRIT
Summary: Update GYP file to use new scripts in GRIT
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Trivial
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-13 11:27 PDT by Adrian Scoica
Modified: 2011-09-14 15:41 PDT (History)
2 users (show)

See Also:


Attachments
Patch (1.86 KB, patch)
2011-09-13 14:25 PDT, Nebojša Ćirić
tony: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adrian Scoica 2011-09-13 11:27:59 PDT
I recently (rev100504) moved all support for Python PAK file manipulation in Chromium into GRIT and I need to tell WebKit to start using the new scripts so that I can remove the dead code.
Comment 1 Nebojša Ćirić 2011-09-13 14:25:08 PDT
Created attachment 107225 [details]
Patch
Comment 2 Nebojša Ćirić 2011-09-13 15:44:33 PDT
Comment on attachment 107225 [details]
Patch

Uploaded patch for Adrian.
Comment 3 WebKit Review Bot 2011-09-14 10:57:37 PDT
Comment on attachment 107225 [details]
Patch

Rejecting attachment 107225 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
 
    name: third_party/snappy/src
    url: From('chromium_deps', 'src/third_party/snappy/src')
    should_process: True
    requirements: set(['third_party', 'chromium_deps', './'])
  
    name: sdch/open-vcdiff
    url: From('chromium_deps', 'src/sdch/open-vcdiff')
    should_process: True
    requirements: set(['sdch', 'chromium_deps', './'])

Died at Tools/Scripts/update-webkit-chromium line 80.
No such file or directory at /mnt/git/webkit-commit-queue/Tools/Scripts/webkitdirs.pm line 1929.

Full output: http://queues.webkit.org/results/9654626
Comment 4 Tony Chang 2011-09-14 15:41:52 PDT
Committed r95132: <http://trac.webkit.org/changeset/95132>