RESOLVED FIXED 68004
Python version check is confusing in test-webkitpy 
https://bugs.webkit.org/show_bug.cgi?id=68004
Summary Python version check is confusing in test-webkitpy
WebKit Review Bot
Reported 2011-09-13 07:57:15 PDT
Python version check is backwards in test-webkitpy Requested by tomz on #webkit.
Attachments
Patch (1.45 KB, patch)
2011-09-13 10:12 PDT, Tom Zakrajsek 		no flags
DetailsFormatted DiffDiff
Patch (1.89 KB, patch)
2011-09-13 14:51 PDT, Tom Zakrajsek 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tom Zakrajsek
Comment 1 2011-09-13 10:12:25 PDT
Created attachment 107189 [details] Patch
Eric Seidel (no email)
Comment 2 2011-09-13 13:08:43 PDT
Comment on attachment 107189 [details] Patch Well, we could check both. But it was intentionally written this way. Anytime you run test-webkitpy with 2.6, you might break machines which only have 2.5 (which is the minimum we require).
Tom Zakrajsek
Comment 3 2011-09-13 13:29:54 PDT
I don't understand. Why would my having 2.6 on my machine and testing with it have any effect on a different machine with 2.5? Are you saying that you'd expect 2.6 to fail and that we actually require *exactly* v2.5? Is the fear that if I did get a failure I might rebaseline with 2.6 and thus break 2.5?
Adam Barth
Comment 4 2011-09-13 13:34:20 PDT
We added this check because we often develop with 2.6 and use a feature that doesn't work in 2.5. When we committed the code, we broke 2.5. Ideally, we should run the tests both in 2.5 and in 2.6. In practice, 2.6 is backwards compatibile with 2.5, so testing in 2.5 is usually sufficient.
Tom Zakrajsek
Comment 5 2011-09-13 14:51:35 PDT
Created attachment 107235 [details] Patch
Adam Barth
Comment 6 2011-09-13 14:54:54 PDT
Comment on attachment 107235 [details] Patch Looks great. Thanks!
WebKit Review Bot
Comment 7 2011-09-15 17:38:40 PDT
Comment on attachment 107235 [details] Patch Clearing flags on attachment: 107235 Committed r95247: <http://trac.webkit.org/changeset/95247>
WebKit Review Bot
Comment 8 2011-09-15 17:38:44 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.