Bug 68004 - Python version check is confusing in test-webkitpy
Summary: Python version check is confusing in test-webkitpy
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tom Zakrajsek
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-13 07:57 PDT by WebKit Review Bot
Modified: 2011-09-15 17:38 PDT (History)
2 users (show)

See Also:


Attachments
Patch (1.45 KB, patch)
2011-09-13 10:12 PDT, Tom Zakrajsek
no flags Details | Formatted Diff | Diff
Patch (1.89 KB, patch)
2011-09-13 14:51 PDT, Tom Zakrajsek
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description WebKit Review Bot 2011-09-13 07:57:15 PDT
Python version check is backwards in test-webkitpy
Requested by tomz on #webkit.
Comment 1 Tom Zakrajsek 2011-09-13 10:12:25 PDT
Created attachment 107189 [details]
Patch
Comment 2 Eric Seidel (no email) 2011-09-13 13:08:43 PDT
Comment on attachment 107189 [details]
Patch

Well, we could check both.  But it was intentionally written this way.  Anytime you run test-webkitpy with 2.6, you might break machines which only have 2.5 (which is the minimum we require).
Comment 3 Tom Zakrajsek 2011-09-13 13:29:54 PDT
I don't understand.  Why would my having 2.6 on my machine and testing with it have any effect on a different machine with 2.5?    Are you saying that you'd expect 2.6 to fail and that we actually require *exactly* v2.5?

Is the fear that if I did get a failure I might rebaseline with 2.6 and thus break 2.5?
Comment 4 Adam Barth 2011-09-13 13:34:20 PDT
We added this check because we often develop with 2.6 and use a feature that doesn't work in 2.5.  When we committed the code, we broke 2.5.  Ideally, we should run the tests both in 2.5 and in 2.6.  In practice, 2.6 is backwards compatibile with 2.5, so testing in 2.5 is usually sufficient.
Comment 5 Tom Zakrajsek 2011-09-13 14:51:35 PDT
Created attachment 107235 [details]
Patch
Comment 6 Adam Barth 2011-09-13 14:54:54 PDT
Comment on attachment 107235 [details]
Patch

Looks great.  Thanks!
Comment 7 WebKit Review Bot 2011-09-15 17:38:40 PDT
Comment on attachment 107235 [details]
Patch

Clearing flags on attachment: 107235

Committed r95247: <http://trac.webkit.org/changeset/95247>
Comment 8 WebKit Review Bot 2011-09-15 17:38:44 PDT
All reviewed patches have been landed.  Closing bug.