Bug 68003 - UpdateChangeLogsWithReviewer should be able to determine reviewer of latest reviewed patch in a bug
Summary: UpdateChangeLogsWithReviewer should be able to determine reviewer of latest r...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tom Zakrajsek
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-13 07:28 PDT by WebKit Review Bot
Modified: 2011-09-15 19:02 PDT (History)
3 users (show)

See Also:

Attachments
Patch (4.40 KB, patch)
2011-09-14 15:29 PDT, Tom Zakrajsek 		no flags Details | Formatted Diff | Diff
Patch (4.70 KB, patch)
2011-09-15 14:06 PDT, Tom Zakrajsek 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description WebKit Review Bot 2011-09-13 07:28:56 PDT 
UpdateChangeLogsWithReviewer should be able to determine reviewer of latest reviewed patch in a bug
Requested by tomz on #webkit.
Comment 1 Tom Zakrajsek 2011-09-14 15:29:37 PDT 
Created attachment 107405 [details]
Patch
Comment 2 Adam Barth 2011-09-14 15:43:46 PDT 
Comment on attachment 107405 [details]
Patch

Nice idea.
Comment 3 Adam Barth 2011-09-14 15:44:09 PDT 
Comment on attachment 107405 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=107405&action=review

> Tools/Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:50
> -        patch = patches[0]
> +        patch = patches[len(patches) - 1]

In Python, you can just write patches[-1]
Comment 4 Eric Seidel (no email) 2011-09-14 15:55:07 PDT 
Comment on attachment 107405 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=107405&action=review

> Tools/Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:47
> +        if len(patches) < 1:

This could also be "not patches"
Comment 5 Tom Zakrajsek 2011-09-15 14:06:32 PDT 
Created attachment 107548 [details]
Patch
Comment 6 Tom Zakrajsek 2011-09-15 14:08:07 PDT 
Implemented idiomatic improvements suggested by Adam and Eric.  Thanks guys.
Comment 7 WebKit Review Bot 2011-09-15 19:02:25 PDT 
Comment on attachment 107548 [details]
Patch

Clearing flags on attachment: 107548

Committed r95257: <http://trac.webkit.org/changeset/95257>
Comment 8 WebKit Review Bot 2011-09-15 19:02:34 PDT 
All reviewed patches have been landed.  Closing bug.