While updating a Chromium working directory I encountered the following errors: --------- S:\src\chromium\src>gclient sync ... ________ running 'svn update S:\src\chromium\src\third_party\WebKit\Source --rev ision 94949 --force --ignore-externals' in 'S:\src\chromium' At revision 94949. ... Enabled Psyco JIT. Updating projects from gyp files... Error: Missing input file src\chrome\browser\policy\configuration_policy_store_interface.h Error: Missing input file src\third_party\WebKit\Source\WebCore\WebCore.gyp\..\platform\graphics\gtk\FontGtk.cpp Error: Missing input file src\third_party\WebKit\Source\WebCore\WebCore.gyp\..\platform\graphics\gtk\FontGtk.cpp Error: Missing input file src\third_party\WebKit\Source\WebCore\WebCore.gyp\..\platform\graphics\gtk\FontGtk.cpp Error: Missing input file src\third_party\WebKit\Source\WebCore\WebCore.gyp\..\platform\graphics\gtk\FontGtk.cpp S:\src\chromium\src>gclient sync --------- In revision 94874 the file was renamed: --------- r94874 | commit-queue@webkit.org | 2011-09-09 17:40:04 -0400 (Fri, 09 Sep 2011) | 13 lines Changed paths: M /trunk/Source/WebCore/ChangeLog M /trunk/Source/WebCore/GNUmakefile.list.am D /trunk/Source/WebCore/platform/graphics/gtk/FontGtk.cpp A /trunk/Source/WebCore/platform/graphics/pango/FontPango.cpp (from /trunk/Source/WebCore/platform/graphics/gtk/FontGtk.cpp:94873) Rename FontGtk.cpp to FontPango.cpp --------- But as of now /trunk/Source/WebCore/WebCore.gypi still references the file. It's simple to remove the stale reference but not as clear whether the new file should be added.
The change to GNUMakefiles.list.am adds FontPango.cpp to webcoregtk if Pango is enabled. The other files that depend on Pango are included in WebCore.gypi (in webcore_files list) as are the other files unconditionally included in webcoregtk. Therefore I infer that it is correct that FontPango.cpp be included in the webcore_files list in WebCore.gypi
Created attachment 107175 [details] Patch
Created attachment 107177 [details] Patch
Comment on attachment 107177 [details] Patch Clearing flags on attachment: 107177 Committed r95029: <http://trac.webkit.org/changeset/95029>
All reviewed patches have been landed. Closing bug.