It's useful when I have to beg someone for fixing builds, bots, etc...
Created attachment 107117 [details] fixes the bug
Comment on attachment 107117 [details] fixes the bug View in context: https://bugs.webkit.org/attachment.cgi?id=107117&action=review > Tools/Scripts/webkitpy/tool/bot/irc_command.py:194 > + if len(contributor.emails) and search_string not in contributor.emails: Upper vs lower case?
Comment on attachment 107117 [details] fixes the bug View in context: https://bugs.webkit.org/attachment.cgi?id=107117&action=review >> Tools/Scripts/webkitpy/tool/bot/irc_command.py:194 >> + if len(contributor.emails) and search_string not in contributor.emails: > > Upper vs lower case? Good point. will fix.
Created attachment 107120 [details] Updated per abarth's comment
(In reply to comment #4) > Created an attachment (id=107120) [details] > Updated per abarth's comment On second thought, it might be a good idea to report the correct email address.
That could be a follow up I guess.
Comment on attachment 107120 [details] Updated per abarth's comment I guess I would have just used the default contributor __str__, as that prints out their default email anyway?
(In reply to comment #7) > (From update of attachment 107120 [details]) > I guess I would have just used the default contributor __str__, as that prints out their default email anyway? So I think that'll only print out the default email.
Comment on attachment 107120 [details] Updated per abarth's comment View in context: https://bugs.webkit.org/attachment.cgi?id=107120&action=review > Tools/Scripts/webkitpy/tool/bot/irc_command.py:194 > + if len(contributor.emails) and search_string.lower() not in map(lambda email: email.lower(), contributor.emails): You can just use contributor.emails, bool([]) is false anyway. Why do you need to check the seach_string? You're trying to avoid printing an email if they gave an email? Won't that be confusing for "darin" since you won't print "darin@apple.com"?
Comment on attachment 107120 [details] Updated per abarth's comment Seems fine.
Comment on attachment 107120 [details] Updated per abarth's comment Whoops. Undo'ing due to Eric's comments.
(In reply to comment #9) > You can just use contributor.emails, bool([]) is false anyway. Ok, will do. > Why do you need to check the seach_string? You're trying to avoid printing an email if they gave an email? > > Won't that be confusing for "darin" since you won't print "darin@apple.com"? In that case, we will print darin@apple.com. That's why I manually search through the list of emails.
Comment on attachment 107120 [details] Updated per abarth's comment With the removal of len(), sure.
Committed r95042: <http://trac.webkit.org/changeset/95042>