Bug 67974 - MSAA: WebKit reports the document state as disabled
Summary: MSAA: WebKit reports the document state as disabled
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows 7
: P2 Normal
Assignee: Jon Honeycutt
URL:
Keywords: InRadar, PlatformOnly
Depends on:
Blocks:
 
Reported: 2011-09-12 17:38 PDT by Jon Honeycutt
Modified: 2011-09-13 16:36 PDT (History)
1 user (show)

See Also:


Attachments
Patch (7.43 KB, patch)
2011-09-12 18:22 PDT, Jon Honeycutt
darin: review+
Details | Formatted Diff | Diff
Patch v2 (4.99 KB, patch)
2011-09-13 15:44 PDT, Jon Honeycutt
bweinstein: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jon Honeycutt 2011-09-12 17:38:19 PDT
The state of the top-level document object in the accessibility tree is unavailable / disabled, causing some clients to ignore it.

<rdar://problem/10095898>
Comment 1 Jon Honeycutt 2011-09-12 18:22:19 PDT
Created attachment 107123 [details]
Patch
Comment 2 Jeff Miller 2011-09-13 07:19:54 PDT
Comment on attachment 107123 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=107123&action=review

> Source/WebCore/ChangeLog:5
> +        <rdar://problem/10095898>

A one sentence description of what was causing the bug would be useful here, i.e. why using isEnabled() for AccessibilityScrollView doesn't work in this case.
Comment 3 Darin Adler 2011-09-13 07:41:31 PDT
Comment on attachment 107123 [details]
Patch

Looks OK to me. I agree with Jeff that this is missing an explanation of why it is necessary to treat documents as enabled in some cases but specifically not for MSAA.
Comment 4 Jon Honeycutt 2011-09-13 15:39:34 PDT
Actually, I can't think of a reason for MSAA to have a special path. I'm going to post a patch that just makes AccessibilityScrollView override isEnabled() and return true.
Comment 5 Jon Honeycutt 2011-09-13 15:44:03 PDT
Created attachment 107245 [details]
Patch v2

Simpler fix.
Comment 6 Jon Honeycutt 2011-09-13 16:36:38 PDT
Landed in <http://trac.webkit.org/changeset/95056>.