Bug 67969 - Implement a HashChangeEvent constructor for V8
Summary: Implement a HashChangeEvent constructor for V8
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 67824
  Show dependency treegraph
 
Reported: 2011-09-12 16:24 PDT by Kentaro Hara
Modified: 2011-09-14 01:32 PDT (History)
5 users (show)

See Also:


Attachments
Patch (4.48 KB, patch)
2011-09-12 16:30 PDT, Kentaro Hara
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kentaro Hara 2011-09-12 16:24:16 PDT
We have been working on implementing constructors of Events. HashChangeEvent has a constructor in JSC (https://bugs.webkit.org/show_bug.cgi?id=67924), but do not have it in V8.
Comment 1 Kentaro Hara 2011-09-12 16:30:58 PDT
Created attachment 107106 [details]
Patch
Comment 2 Nate Chapin 2011-09-13 16:36:25 PDT
Comment on attachment 107106 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=107106&action=review

> Source/WebCore/dom/HashChangeEvent.idl:26
> -        CustomConstructFunction
> +        CustomConstructFunction,
> +        V8CustomConstructor

It looks like there's substantial overlap between these two attributes.  Is there any chance we could merge them?
Comment 3 Hajime Morrita 2011-09-13 17:00:58 PDT
Comment on attachment 107106 [details]
Patch

Haraken should respond Chapin's comment.
Comment 4 WebKit Review Bot 2011-09-13 18:04:34 PDT
Comment on attachment 107106 [details]
Patch

Clearing flags on attachment: 107106

Committed r95063: <http://trac.webkit.org/changeset/95063>
Comment 5 WebKit Review Bot 2011-09-13 18:04:39 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Kentaro Hara 2011-09-14 01:32:11 PDT
(In reply to comment #2)
> (From update of attachment 107106 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=107106&action=review
> 
> > Source/WebCore/dom/HashChangeEvent.idl:26
> > -        CustomConstructFunction
> > +        CustomConstructFunction,
> > +        V8CustomConstructor
> 
> It looks like there's substantial overlap between these two attributes.  Is there any chance we could merge them?

Sure! I will do it sometime soon.