Bug 67957 - Possible ASSERT(!storageTracker) in Lazily Initialized StorageTracker
Summary: Possible ASSERT(!storageTracker) in Lazily Initialized StorageTracker
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2011-09-12 15:14 PDT by Joseph Pecoraro
Modified: 2011-09-12 21:40 PDT (History)
4 users (show)

See Also:


Attachments
[PATCH] Proposed Fix (2.16 KB, patch)
2011-09-12 16:37 PDT, Joseph Pecoraro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2011-09-12 15:14:09 PDT
StorageTracker::initializeTracker ASSERTs:

    ASSERT(!storageTracker);

However that global static could have been initialized by a call
to StorageTracker::tracker. We should instead ASSERT that the
tracker doesn't exist yet (we create it here) or if it does exist
that it doesn't yet have a client (which is what initialize is doing).
Comment 1 Joseph Pecoraro 2011-09-12 16:37:47 PDT
Created attachment 107110 [details]
[PATCH] Proposed Fix
Comment 2 Joseph Pecoraro 2011-09-12 16:38:46 PDT
<rdar://problem/10064708>
Comment 3 Darin Adler 2011-09-12 16:46:19 PDT
Comment on attachment 107110 [details]
[PATCH] Proposed Fix

Seems fine.
Comment 4 WebKit Review Bot 2011-09-12 21:40:49 PDT
Comment on attachment 107110 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 107110

Committed r95013: <http://trac.webkit.org/changeset/95013>
Comment 5 WebKit Review Bot 2011-09-12 21:40:53 PDT
All reviewed patches have been landed.  Closing bug.