Bug 67956 - DFG JIT always speculates that ValueAdd is a numeric addition
Summary: DFG JIT always speculates that ValueAdd is a numeric addition
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-12 15:10 PDT by Filip Pizlo
Modified: 2011-09-14 19:02 PDT (History)
3 users (show)

See Also:


Attachments
the patch (9.61 KB, patch)
2011-09-12 15:45 PDT, Filip Pizlo
ggaren: review+
webkit-ews: commit-queue-
Details | Formatted Diff | Diff
the patch - disable tiering (9.16 KB, patch)
2011-09-12 16:17 PDT, Filip Pizlo
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2011-09-12 15:10:28 PDT
DFG JIT always speculates that ValueAdd is a numerical addition even when there is evidence to the contrary.  This causes all uses of "+" for string concatenation to fall off the speculative path.
Comment 1 Filip Pizlo 2011-09-12 15:45:30 PDT
Created attachment 107095 [details]
the patch
Comment 2 Geoffrey Garen 2011-09-12 15:50:19 PDT
Comment on attachment 107095 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=107095&action=review

r=me

> Source/JavaScriptCore/wtf/Platform.h:968
> -#define ENABLE_TIERED_COMPILATION 0
> +#define ENABLE_TIERED_COMPILATION 1

Oops?
Comment 3 Early Warning System Bot 2011-09-12 16:02:47 PDT
Comment on attachment 107095 [details]
the patch

Attachment 107095 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/9649142
Comment 4 Filip Pizlo 2011-09-12 16:11:49 PDT
(In reply to comment #2)
> (From update of attachment 107095 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=107095&action=review
> 
> r=me
> 
> > Source/JavaScriptCore/wtf/Platform.h:968
> > -#define ENABLE_TIERED_COMPILATION 0
> > +#define ENABLE_TIERED_COMPILATION 1
> 
> Oops?

Oops indeed!
Comment 5 Filip Pizlo 2011-09-12 16:17:52 PDT
Created attachment 107103 [details]
the patch - disable tiering

Will wait for bots before committing.
Comment 6 Filip Pizlo 2011-09-12 16:54:25 PDT
It's probably best to land this after the OSR patches land.  Leaving it up here until then.
Comment 7 Filip Pizlo 2011-09-14 19:02:44 PDT
Landed in r95147.