RESOLVED FIXED 67932
Web Inspector: event dividers do not update timeline boundaries. 
https://bugs.webkit.org/show_bug.cgi?id=67932
Summary Web Inspector: event dividers do not update timeline boundaries.
Pavel Feldman
Reported 2011-09-12 06:32:51 PDT
Events (as resources) should update timeline boundaries.
Attachments
Patch (3.09 KB, patch)
2011-09-12 06:34 PDT, Pavel Feldman 		tonyg: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Pavel Feldman
Comment 1 2011-09-12 06:34:42 PDT
Created attachment 107048 [details] Patch
Ilya Tikhonovsky
Comment 2 2011-09-12 07:33:16 PDT
Comment on attachment 107048 [details] Patch LGTM
Tony Gentilcore
Comment 3 2011-09-12 08:03:59 PDT
Comment on attachment 107048 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=107048&action=review > Source/WebCore/inspector/front-end/NetworkPanel.js:630 > + // Schedule refresh to update boundaries and draw the new line. Up to you, but both of these comments seem a bit gratuitous. They don't convey much more info than the method name. > Source/WebCore/inspector/front-end/NetworkPanel.js:667 > + boundariesChanged = this.calculator.updateBoundariesForEventTime(this._mainResourceDOMContentTime) || boundariesChanged; Cleaner to use |= for these two, right?
Pavel Feldman
Comment 4 2011-09-12 08:19:29 PDT
Comment on attachment 107048 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=107048&action=review >> Source/WebCore/inspector/front-end/NetworkPanel.js:667 >> + boundariesChanged = this.calculator.updateBoundariesForEventTime(this._mainResourceDOMContentTime) || boundariesChanged; > > Cleaner to use |= for these two, right? Not really: - |= is bitwise operator - I need boundaries to be updated even when boundariesChanged is true.
Pavel Feldman
Comment 5 2011-09-12 08:21:42 PDT
Committed r94957: <http://trac.webkit.org/changeset/94957>
Note You need to log in before you can comment on or make changes to this bug.