Events (as resources) should update timeline boundaries.
Created attachment 107048 [details] Patch
Comment on attachment 107048 [details] Patch LGTM
Comment on attachment 107048 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=107048&action=review > Source/WebCore/inspector/front-end/NetworkPanel.js:630 > + // Schedule refresh to update boundaries and draw the new line. Up to you, but both of these comments seem a bit gratuitous. They don't convey much more info than the method name. > Source/WebCore/inspector/front-end/NetworkPanel.js:667 > + boundariesChanged = this.calculator.updateBoundariesForEventTime(this._mainResourceDOMContentTime) || boundariesChanged; Cleaner to use |= for these two, right?
Comment on attachment 107048 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=107048&action=review >> Source/WebCore/inspector/front-end/NetworkPanel.js:667 >> + boundariesChanged = this.calculator.updateBoundariesForEventTime(this._mainResourceDOMContentTime) || boundariesChanged; > > Cleaner to use |= for these two, right? Not really: - |= is bitwise operator - I need boundaries to be updated even when boundariesChanged is true.
Committed r94957: <http://trac.webkit.org/changeset/94957>