Bug 67928 - [Qt] Build fails after r94920 with strict compiler
Summary: [Qt] Build fails after r94920 with strict compiler
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All Linux
: P2 Normal
Assignee: Andras Becsi
URL:
Keywords:
Depends on:
Blocks: 43191
  Show dependency tree / graph
 
Reported: 2011-09-12 03:56 PDT by Andras Becsi
Modified: 2011-09-12 06:34 PDT (History)
2 users (show)

See Also:

Attachments
proposed fix (2.66 KB, patch)
2011-09-12 03:59 PDT, Andras Becsi 		cmarcelo: review-
Details | Formatted Diff | Diff
proposed patch (2.77 KB, patch)
2011-09-12 06:06 PDT, Andras Becsi 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andras Becsi 2011-09-12 03:56:04 PDT 
The newly added wtf/RedBlackTree.h contains the variable Node* updateStart which is set but never used. This gives an error on newer gcc when Werror is set. Remove this dead variable.
Comment 1 Andras Becsi 2011-09-12 03:59:23 PDT 
Created attachment 107036 [details]
proposed fix
Comment 2 Caio Marcelo de Oliveira Filho 2011-09-12 04:49:20 PDT 
LGTM, although I'm not a reviewer.

New Red Black tree is based on PODRedBlackTree.h. The 'updateStart' variable was used to call 'updateNode' on the ascendants of the topmost updated node. The new one (RedBlackTree.h) doesn't have this functionality, so it is OK to remove.
Comment 3 Caio Marcelo de Oliveira Filho 2011-09-12 05:00:14 PDT 
Comment on attachment 107036 [details]
proposed fix

View in context: https://bugs.webkit.org/attachment.cgi?id=107036&action=review

Ops. Doesn't LGTM yet :P

> Source/JavaScriptCore/wtf/RedBlackTree.h:-196
> -                    Node* newSubTreeRoot = rightRotate(x->parent()->parent());

You need to keep this rightRotate, just ignore the return value.

> Source/JavaScriptCore/wtf/RedBlackTree.h:-218
> -                    Node* newSubTreeRoot = leftRotate(x->parent()->parent());

You need to keep this leftRotate, just ignore the return value.
Comment 4 Andras Becsi 2011-09-12 06:06:50 PDT 
Created attachment 107043 [details]
proposed patch
Comment 5 Csaba Osztrogonác 2011-09-12 06:24:56 PDT 
Comment on attachment 107043 [details]
proposed patch

LGTM, r=me. ( But cq-, because commit queue still doesn't like my name :( )
Comment 6 Andras Becsi 2011-09-12 06:33:14 PDT 
Committed r94954: <http://trac.webkit.org/changeset/94954>
Comment 7 Andras Becsi 2011-09-12 06:34:16 PDT 
Comment on attachment 107043 [details]
proposed patch

Clearing flags from landed patch.