Bug 67884 – Delete button icon does not properly update when the device resolution changes dynamically

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Beth Dakin]

https://bugs.webkit.org/show_bug.cgi?id=67819 added high resolution platform images to WebCore. The delete button, however, does not dynamically update to the appropriate resolution when the device scale factor changes dynamically.

[Beth Dakin]

<rdar://problem/10104632>

[Beth Dakin]

Created attachment 107562 [details]
Patch

[Darin Adler]

Comment on attachment 107562 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=107562&action=review

> Source/WebCore/ChangeLog:15
> +        takes an optional bool parameter indicated whether or not the change affects the 
> +        Editor since page scale changes don't affect Editor.

It seems like the bool parameter indicates whether it’s the device scale factor changing or the page scale factor changing. Calling it “affectsEditor” seems kind of wrong.

Instead of adding a bool and attaching the deviceScaleFactorChanged work into the existing function, I suggest putting the code to iterate all the frames and call deviceScaleFactorChanged on each editor directly into Page::setDeviceScaleFactor. You wouldn’t have to touch Frame.h/cpp at all. Iterating all the frames in a page is simple and can be done without recursion.

[Beth Dakin]

Created attachment 107567 [details]
Patch

[Beth Dakin]

Thanks! Fixed with revision 95244.