Bug 67884 - Delete button icon does not properly update when the device resolution changes dynamically
Summary: Delete button icon does not properly update when the device resolution change...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Beth Dakin
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2011-09-09 23:31 PDT by Beth Dakin
Modified: 2011-09-15 17:17 PDT (History)
1 user (show)

See Also:


Attachments
Patch (6.16 KB, patch)
2011-09-15 16:19 PDT, Beth Dakin
darin: review-
Details | Formatted Diff | Diff
Patch (4.06 KB, patch)
2011-09-15 17:01 PDT, Beth Dakin
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Beth Dakin 2011-09-09 23:31:09 PDT
https://bugs.webkit.org/show_bug.cgi?id=67819 added high resolution platform images to WebCore. The delete button, however, does not dynamically update to the appropriate resolution when the device scale factor changes dynamically.
Comment 1 Beth Dakin 2011-09-09 23:33:21 PDT
<rdar://problem/10104632>
Comment 2 Beth Dakin 2011-09-15 16:19:41 PDT
Created attachment 107562 [details]
Patch
Comment 3 Darin Adler 2011-09-15 16:31:36 PDT
Comment on attachment 107562 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=107562&action=review

> Source/WebCore/ChangeLog:15
> +        takes an optional bool parameter indicated whether or not the change affects the 
> +        Editor since page scale changes don't affect Editor.

It seems like the bool parameter indicates whether it’s the device scale factor changing or the page scale factor changing. Calling it “affectsEditor” seems kind of wrong.

Instead of adding a bool and attaching the deviceScaleFactorChanged work into the existing function, I suggest putting the code to iterate all the frames and call deviceScaleFactorChanged on each editor directly into Page::setDeviceScaleFactor. You wouldn’t have to touch Frame.h/cpp at all. Iterating all the frames in a page is simple and can be done without recursion.
Comment 4 Beth Dakin 2011-09-15 17:01:04 PDT
Created attachment 107567 [details]
Patch
Comment 5 Beth Dakin 2011-09-15 17:17:25 PDT
Thanks! Fixed with revision 95244.