Bug 67881 - Remove support for anonymous storage from jsobjects
Summary: Remove support for anonymous storage from jsobjects
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Oliver Hunt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-09 19:14 PDT by Oliver Hunt
Modified: 2011-09-11 14:10 PDT (History)
0 users

See Also:


Attachments
Patch (135.76 KB, patch)
2011-09-09 19:19 PDT, Oliver Hunt
no flags Details | Formatted Diff | Diff
Patch (135.81 KB, patch)
2011-09-09 21:34 PDT, Oliver Hunt
no flags Details | Formatted Diff | Diff
Patch (138.85 KB, patch)
2011-09-09 21:54 PDT, Oliver Hunt
no flags Details | Formatted Diff | Diff
Patch (139.25 KB, patch)
2011-09-09 22:33 PDT, Oliver Hunt
no flags Details | Formatted Diff | Diff
Patch (139.24 KB, patch)
2011-09-10 14:31 PDT, Oliver Hunt
sam: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Oliver Hunt 2011-09-09 19:14:40 PDT
Remove support for anonymous storage from jsobjects
Comment 1 Oliver Hunt 2011-09-09 19:19:58 PDT
Created attachment 106954 [details]
Patch
Comment 2 Oliver Hunt 2011-09-09 21:34:48 PDT
Created attachment 106960 [details]
Patch
Comment 3 Early Warning System Bot 2011-09-09 21:46:58 PDT
Comment on attachment 106960 [details]
Patch

Attachment 106960 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/9634031
Comment 4 Oliver Hunt 2011-09-09 21:54:56 PDT
Created attachment 106961 [details]
Patch
Comment 5 Oliver Hunt 2011-09-09 22:33:52 PDT
Created attachment 106962 [details]
Patch
Comment 6 WebKit Review Bot 2011-09-10 00:28:18 PDT
Comment on attachment 106962 [details]
Patch

Attachment 106962 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/9627827
Comment 7 WebKit Review Bot 2011-09-10 01:33:45 PDT
Comment on attachment 106962 [details]
Patch

Attachment 106962 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/9635011
Comment 8 Oliver Hunt 2011-09-10 14:31:42 PDT
Created attachment 106983 [details]
Patch
Comment 9 Oliver Hunt 2011-09-10 15:38:11 PDT
Mac build failure appears to be bogus -- i have made multiple clean debug and release builds, and the ews bot doesn't say what the error it believes exists is.
Comment 10 WebKit Review Bot 2011-09-10 16:29:18 PDT
Comment on attachment 106983 [details]
Patch

Attachment 106983 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/9635248
Comment 11 Sam Weinig 2011-09-10 17:12:36 PDT
Comment on attachment 106983 [details]
Patch

Please make sure to watch the bots on landing.  It is odd for there to be a spurious build failure on the EWS likes this.  We really should move to a system that can keep the entire the build output though :\.
Comment 12 WebKit Review Bot 2011-09-10 17:29:31 PDT
Comment on attachment 106983 [details]
Patch

Attachment 106983 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/9634316
Comment 13 Oliver Hunt 2011-09-11 14:10:28 PDT
Committed r94929: <http://trac.webkit.org/changeset/94929>