Bug 67865 - [V8] V8WebKitPoint::constructorCallback leaks
Summary: [V8] V8WebKitPoint::constructorCallback leaks
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Julien Chaffraix
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-09 14:24 PDT by Julien Chaffraix
Modified: 2011-09-09 18:15 PDT (History)
4 users (show)

See Also:


Attachments
Proposed change: use toV8 and correct RefPtr usage. (1.74 KB, patch)
2011-09-09 14:32 PDT, Julien Chaffraix
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Julien Chaffraix 2011-09-09 14:24:06 PDT
Seen under valgrind while testing LayoutTests/fast/js/instanceof-XMLHTTPRequest.html.

Also using a PassRefPtr in this code is not right.
Comment 1 Julien Chaffraix 2011-09-09 14:32:18 PDT
Created attachment 106924 [details]
Proposed change: use toV8 and correct RefPtr usage.
Comment 2 Adam Barth 2011-09-09 17:07:35 PDT
Comment on attachment 106924 [details]
Proposed change: use toV8 and correct RefPtr usage.

Wow.
Comment 3 Adam Barth 2011-09-09 17:08:07 PDT
Looks like the leak was added by japhet and reviewed by dglazkov two years ago in http://trac.webkit.org/changeset/48834
Comment 4 Julien Chaffraix 2011-09-09 17:15:08 PDT
Comment on attachment 106924 [details]
Proposed change: use toV8 and correct RefPtr usage.

Thanks Adam!
Comment 5 WebKit Review Bot 2011-09-09 18:15:19 PDT
Comment on attachment 106924 [details]
Proposed change: use toV8 and correct RefPtr usage.

Clearing flags on attachment: 106924

Committed r94894: <http://trac.webkit.org/changeset/94894>
Comment 6 WebKit Review Bot 2011-09-09 18:15:23 PDT
All reviewed patches have been landed.  Closing bug.