Bug 67862 - Removed ENABLE(SINGLE_THREADED) support, since it is always false
Summary: Removed ENABLE(SINGLE_THREADED) support, since it is always false
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Geoffrey Garen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-09 13:29 PDT by Geoffrey Garen
Modified: 2011-09-09 17:04 PDT (History)
1 user (show)

See Also:


Attachments
patch (9.96 KB, patch)
2011-09-09 13:29 PDT, Geoffrey Garen
no flags Details | Formatted Diff | Diff
patch (10.42 KB, patch)
2011-09-09 14:25 PDT, Geoffrey Garen
mitz: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Geoffrey Garen 2011-09-09 13:29:37 PDT
Created attachment 106911 [details]
patch

Next step toward making the baseline platform assumption that threads exist.
Comment 1 WebKit Review Bot 2011-09-09 13:31:19 PDT
Attachment 106911 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1

Source/JavaScriptCore/ChangeLog:3:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Source/WebCore/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 2 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 2 Geoffrey Garen 2011-09-09 14:25:06 PDT
Created attachment 106922 [details]
patch

improved changelog
Comment 3 mitz 2011-09-09 15:52:05 PDT
Comment on attachment 106922 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=106922&action=review

r=me if the bots approve

> JavaScriptCore/ChangeLog:21
> +        * wtf/wtf.pri: Removed now-dead code.

You actually removed a reference to ThreadingNone.cpp here.

> WebCore/ChangeLog:12
> +        * WebCore.pri:
> +        * features.pri: Removed references to
> +        ThreadingNone.cpp, which was only compiled in single-threaded mode.

You actually removed now-dead code here.
Comment 4 Geoffrey Garen 2011-09-09 16:58:33 PDT
The EWS bots that have a chance of finishing are green, so I think this is a go.
Comment 5 Geoffrey Garen 2011-09-09 17:04:33 PDT
Committed r94890: <http://trac.webkit.org/changeset/94890>