Bug 67855 - Buildbot may use RunWebKitTest's evaluateCommand on bots that run nrwt
Summary: Buildbot may use RunWebKitTest's evaluateCommand on bots that run nrwt
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 64812
  Show dependency treegraph
 
Reported: 2011-09-09 10:15 PDT by Ryosuke Niwa
Modified: 2011-09-09 11:20 PDT (History)
4 users (show)

See Also:


Attachments
fixes the bug (2.82 KB, patch)
2011-09-09 10:17 PDT, Ryosuke Niwa
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2011-09-09 10:15:55 PDT
Some ports use RunWebKitTests instead of NewRunWebKitTests to run tests, and using RunWebKitTests.evaluateCommand after calling _parseNewRunWebKitTestsOutput.
Comment 1 Ryosuke Niwa 2011-09-09 10:17:17 PDT
Created attachment 106885 [details]
fixes the bug
Comment 2 Ryosuke Niwa 2011-09-09 10:38:16 PDT
We really need this patch landed ASAP. Right now, this bug is making Mac bots red.
Comment 3 Dirk Pranke 2011-09-09 10:54:34 PDT
Comment on attachment 106885 [details]
fixes the bug

Shouldn't we switch the ports that are using RunWebKitTests to NewRunWebKitTests instead of modifying both evaluateCommands ?
Comment 4 Ryosuke Niwa 2011-09-09 11:07:38 PDT
(In reply to comment #3)
> (From update of attachment 106885 [details])
> Shouldn't we switch the ports that are using RunWebKitTests to NewRunWebKitTests instead of modifying both evaluateCommands ?

We can't because some of bots are still in the process of transitioning and we may need to move it back.
Comment 5 Dirk Pranke 2011-09-09 11:16:23 PDT
Comment on attachment 106885 [details]
fixes the bug

Per conversation over IRC, some (most?) bots are invoking NRWT through the run-webkit-tests wrapper, and so they we need to update the parser in the wrapper command. R+. We really need to consolidate these things and finish the cutover though ...
Comment 6 Ryosuke Niwa 2011-09-09 11:20:50 PDT
Comment on attachment 106885 [details]
fixes the bug

Clearing flags on attachment: 106885

Committed r94868: <http://trac.webkit.org/changeset/94868>
Comment 7 Ryosuke Niwa 2011-09-09 11:20:54 PDT
All reviewed patches have been landed.  Closing bug.