Bug 67848 – [chromium] Workaround for String/HashSet/StringHash #include order glitch

• Status: RESOLVED
• Resolution: WONTFIX
• Component: New Bugs

[Iain Merrick]

[chromium] Workaround for String/HashSet/StringHash #include order glitch

[Iain Merrick]

Created attachment 106869 [details]
Patch

[Iain Merrick]

Kind of a long explanation for a one-line change, but it's bit of a head-scratcher.

[Nat Duca]

+kbr who knows this file pretty well.

[Iain Merrick]

Simple version: nobody actually includes StringHash.h! So this doesn't compile:

#include <wtf/HashSet.h>
#include <wtf/text/WTFString.h>

class ScoobyDoo {
  HashSet<String> scrappy;
};

#include <wtf/text/StringHash.h>

I think this *does* mean we were using the wrong hash traits.

The only core header that includes StringHash.h is WTFThreadData.h, which is why it showed up when I had thread-related code and GraphicsContext3D in the same .cpp file.

[Kenneth Russell]

Comment on attachment 106869 [details]
Patch

This seems awfully suspicious because there are some files (like Extensions3DChromium.cpp) which compile just fine and include only their header, GraphicsContext3D.h and GraphicsContext3DPrivate.h -- and GraphicsContext3DPrivate.h already includes GraphicsContext3D.h. Could you please continue to investigate the underlying problem rather than committing this workaround, which isn't necessary for the sources currently in the tree?

[James Robinson]

Comment on attachment 106869 [details]
Patch

If there's a problem with the string headers, fix the string headers.

[Iain Merrick]

Here's the fix for the string headers: https://bugs.webkit.org/show_bug.cgi?id=67851

[Kenneth Russell]

(In reply to comment #7)
> Here's the fix for the string headers: https://bugs.webkit.org/show_bug.cgi?id=67851

Thanks. After looking at the comments on that other bug it seems that there was a deliberate decision to avoid including the hash traits from all files which include WTFString.h. Given that, I think this fix to GraphicsContext3DPrivate.h is the right thing to do. I'll r+ this and you can close the other one as WontFix.

[Iain Merrick]

Obsoleted by https://bugs.webkit.org/show_bug.cgi?id=67851