[skia] remove dead code, no functionality change
Created attachment 106865 [details] Patch
Comment on attachment 106865 [details] Patch Attachment 106865 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/9622849 New failing tests: svg/W3C-SVG-1.1/animate-elem-04-t.svg platform/chromium/fast/text/text-stroke-with-border.html scrollbars/scrollbar-orientation.html scrollbars/disabled-scrollbar.html scrollbars/scrollbar-buttons.html platform/mac-snowleopard/platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment.html scrollbars/listbox-scrollbar-combinations.html scrollbars/scrollbar-click-does-not-blur-content.html svg/W3C-SVG-1.1/animate-elem-02-t.svg svg/W3C-SVG-1.1/animate-elem-05-t.svg scrollbars/scrollbars-on-positioned-content.html scrollbars/overflow-scrollbar-combinations.html scrollbars/basic-scrollbar.html scrollbars/scrollbar-middleclick-nopaste.html svg/W3C-SVG-1.1/animate-elem-03-t.svg
Comment on attachment 106865 [details] Patch The EWS bot doesn't seem to think this is dead code. Can you check if those failures are due to this patch?
Created attachment 106889 [details] Patch
My read of the failure of cr-linux was that it didn't pass w/o my patch, plus my change is strictly in a windows-only file, so I'm having trouble seeing how it affected the linux bot. Am I misreading this?
> Am I misreading this? It is hard to see how changing this file could effect Linux. It's certainly possible the bot is confused.
rebaselined (just in case) and resubmitted (with no changes) to trigger another stab at cr-linux...
Comment on attachment 106889 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=106889&action=review Looks good but ChangeLog needs a minor update. r=me > Source/WebCore/ChangeLog:8 > + No new tests. (OOPS!) That OOPS will trigger a problem during commit.
Comment on attachment 106889 [details] Patch Rejecting attachment 106889 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: abf2546dd1a2ed81c56c4c6ee34cd6b74bcb84c5 r94956 = f5aad96879400e3b3556e085f2c15249f6183cee Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Updating chromium port dependencies using gclient... ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/9647004
Created attachment 107053 [details] Patch
just updated ChangeLog
Comment on attachment 107053 [details] Patch resending to commit bot, as only the ChangeLog seemed to be at issue.
Comment on attachment 107053 [details] Patch Rejecting attachment 107053 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 Last 500 characters of output: hangeLog does not appear to be a valid reviewer according to committers.py. ERROR: /mnt/git/webkit-commit-queue/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Updating OpenSource Current branch master is up to date. Updating chromium port dependencies using gclient... ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/9646023
Comment on attachment 107053 [details] Patch looking for + or rubberstamp to resubmit after fixing ChangeLog
Comment on attachment 107053 [details] Patch Looks fine.
Comment on attachment 107053 [details] Patch Clearing flags on attachment: 107053 Committed r94961: <http://trac.webkit.org/changeset/94961>
All reviewed patches have been landed. Closing bug.