Bug 67838 - Web Inspector: introduce JavaScriptSourceFrame class.
Summary: Web Inspector: introduce JavaScriptSourceFrame class.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Podivilov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-09 03:53 PDT by Pavel Podivilov
Modified: 2011-09-09 08:20 PDT (History)
10 users (show)

See Also:


Attachments
Patch (6.90 KB, patch)
2011-09-09 03:54 PDT, Pavel Podivilov
no flags Details | Formatted Diff | Diff
Patch (13.47 KB, patch)
2011-09-09 04:21 PDT, Pavel Podivilov
pfeldman: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Podivilov 2011-09-09 03:53:29 PDT
Web Inspector: introduce JavaScriptSourceFrame class.

SourceFrame should not deal with JavaScript debugging since it is a base class for all source frame implementations.
Comment 1 Pavel Podivilov 2011-09-09 03:54:37 PDT
Created attachment 106857 [details]
Patch
Comment 2 Pavel Feldman 2011-09-09 03:59:06 PDT
You should probably move SourceFrameDelegateForScriptsPanel implementation into the new class right away.
Comment 3 Pavel Podivilov 2011-09-09 04:21:42 PDT
Created attachment 106861 [details]
Patch
Comment 4 Pavel Podivilov 2011-09-09 04:22:14 PDT
(In reply to comment #2)
> You should probably move SourceFrameDelegateForScriptsPanel implementation into the new class right away.

Good point!
Comment 5 Pavel Podivilov 2011-09-09 08:20:50 PDT
Committed r94855: <http://trac.webkit.org/changeset/94855>