Bug 67836 - REGRESSION(r94536): breaks absoluteLocation() of RelatedMouseEvent (Requested by jknotten on #webkit).
Summary: REGRESSION(r94536): breaks absoluteLocation() of RelatedMouseEvent (Requested...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: WebKit Review Bot
URL:
Keywords:
Depends on:
Blocks: 67592
  Show dependency tree / graph
 
Reported: 2011-09-09 03:21 PDT by WebKit Review Bot
Modified: 2011-09-09 03:31 PDT (History)
2 users (show)

See Also:

Attachments
ROLLOUT of r94536 (5.69 KB, patch)
2011-09-09 03:22 PDT, WebKit Review Bot 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description WebKit Review Bot 2011-09-09 03:21:59 PDT 
http://trac.webkit.org/changeset/94536 broke the build:
breaks absoluteLocation() of RelatedMouseEvent (Requested by jknotten on #webkit).

This is an automatic bug report generated by the sheriff-bot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests case pain.

"Only you can prevent forest fires." -- Smokey the Bear
Comment 1 WebKit Review Bot 2011-09-09 03:22:26 PDT 
Created attachment 106854 [details]
ROLLOUT of r94536

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the rollout will be successful.  This process takes approximately 15 minutes.

If you would like to land the rollout faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID --ignore-builders

where ATTACHMENT_ID is the ID of this attachment.
Comment 2 John Knottenbelt 2011-09-09 03:25:48 PDT 
My original change breaks the absolutePosition member of MouseRelatedEvent, because I didn't undo the "taking page scale into account". Also, question from Simon Fraser deserves further investigation, so rolling out my change for now.
Comment 3 WebKit Review Bot 2011-09-09 03:31:21 PDT 
Comment on attachment 106854 [details]
ROLLOUT of r94536

Clearing flags on attachment: 106854

Committed r94843: <http://trac.webkit.org/changeset/94843>
Comment 4 WebKit Review Bot 2011-09-09 03:31:26 PDT 
All reviewed patches have been landed.  Closing bug.