Bug 67825 – Implement a WebKitAnimationEvent constructor for JSC

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Kentaro Hara]

We have been working on implementing constructors of Events. WebKitAnimationEvent should have a constructor. 

There is no spec for the WebKitAnimationEvent constructor, since it is WebKit-specific. Based on the current IDL of initWebKitAnimationEvent(), the IDL of the WebKitAnimationEvent constructor should be as follows.                                                          

[Constructor(DOMString type, optional WebKitAnimationEvent eventInitDict)]     
dictionary WebKitAnimationEventInit : EventInit {
    DOMString animationName;
    double elapsedTime;
}

[Kentaro Hara]

Created attachment 106825 [details]
Patch

[Sam Weinig]

The Constructor would be on the WebKitAnimationEvent, not the WebKitAnimationEventInit.

[Sam Weinig]

Comment on attachment 106825 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=106825&action=review

> Source/WebCore/ChangeLog:17
> +        [Constructor(DOMString type, optional WebKitAnimationEventInit eventInitDict)]
> +        dictionary WebKitAnimationEventInit : EventInit {
> +            DOMString animationName;
> +            double elapsedTime;
> +        }

This is not what the IDL would look like.  The constructor would be on the Event itself, not the Init.

[Kentaro Hara]

(In reply to comment #2)
> The Constructor would be on the WebKitAnimationEvent, not the WebKitAnimationEventInit.

Sorry.

Correct IDL:

[Constructor(DOMString type, optional WebKitAnimationEventInit eventInitDict)]
dictionary WebKitAnimationEventInit : EventInit {
    DOMString animationName;
    double elapsedTime;
}

[Kentaro Hara]

(In reply to comment #3)
> (From update of attachment 106825 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=106825&action=review
> 
> > Source/WebCore/ChangeLog:17
> > +        [Constructor(DOMString type, optional WebKitAnimationEventInit eventInitDict)]
> > +        dictionary WebKitAnimationEventInit : EventInit {
> > +            DOMString animationName;
> > +            double elapsedTime;
> > +        }
> 
> This is not what the IDL would look like.  The constructor would be on the Event itself, not the Init.

Sorry for the confusion. I omitted the interface part since this patch does not change it....

[Constructor(DOMString type, optional WebKitAnimationEventInit eventInitDict)]
interface WebKitAnimationEvent : Event {
    ...;
}

dictionary WebKitAnimationEventInit : EventInit {
    DOMString animationName;
    double elapsedTime;
}

I will correct Changelog as above. Thanks!

[Roland Steiner]

Committed r94861: <http://trac.webkit.org/changeset/94861>

[Simon Fraser (smfr)]

Why were no animation people cc'd on this?

[Sam Weinig]

It's not really animation related, just progressing through all the events, adding constructors.