Bug 67814 - [Qt] Remove common.pri
Summary: [Qt] Remove common.pri
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Qt
Depends on:
Blocks:
 
Reported: 2011-09-08 16:03 PDT by Laszlo Gombos
Modified: 2011-09-09 11:10 PDT (History)
4 users (show)

See Also:

Attachments
Proposed patch (4.04 KB, patch)
2011-09-08 16:10 PDT, Laszlo Gombos 		kling: review+
kling: commit-queue-
Details | Formatted Diff | Diff
for cq. This time used svn to create the patch (4.88 KB, patch)
2011-09-09 10:11 PDT, Laszlo Gombos 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Laszlo Gombos 2011-09-08 16:03:28 PDT 
It seems to me that common.pri does not have a defined "identity". The content of common.pri could be just moved to WebKit.pri as WebKit.pri gets already included for the relevant .pro files where common.pri is included. In addition common.pri is not quite "common" as it is not included for every WebKit pro file (as an example WebProcess.pro does not include common.pri). I propose to remove common.pri.

Alternatively we can define a purpose for common.pri and use it consistently.
Comment 1 Laszlo Gombos 2011-09-08 16:10:57 PDT 
Created attachment 106808 [details]
Proposed patch
Comment 2 Andreas Kling 2011-09-09 04:06:06 PDT 
Comment on attachment 106808 [details]
Proposed patch

r=me.
The patch is missing the hunk to kill common.pri though, so cq-.
Comment 3 Laszlo Gombos 2011-09-09 10:11:33 PDT 
Created attachment 106883 [details]
for cq. This time used svn to create the patch
Comment 4 WebKit Review Bot 2011-09-09 11:10:08 PDT 
Comment on attachment 106883 [details]
for cq. This time used svn to create the patch

Clearing flags on attachment: 106883

Committed r94866: <http://trac.webkit.org/changeset/94866>
Comment 5 WebKit Review Bot 2011-09-09 11:10:13 PDT 
All reviewed patches have been landed.  Closing bug.